-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VideoCdn] Add new extractor #31481
base: master
Are you sure you want to change the base?
[VideoCdn] Add new extractor #31481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I've made a few comments.
Also, if there's some standard embedding that's used with this host, that embedding should be supported in the generic extractor.
Co-authored-by: dirkf <fieldhouse@gmx.net>
…bunse/youtube-dl into feature/add_videocdn_extractor
Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored-by: dirkf <fieldhouse@gmx.net>
I see so many different ways videos from this cdn are embedded, e.g. via a clickable image without any hint on the 'player-id' or a div element with |
These pages don't even mention the video host in the non-JS HTML seen by yt-dl:
This has each video link as the value of the Embedded links of the above type could be extracted. yt-dl doesn't find links like this by default (#12692, #6216) but a lot of extractors are doing something similar: <iframe> extraction list
In due course we'll follow this refactoring of the generic extractor from yt-dlp. If a routine is added for this case, it should use the APIs there, eg add a local IE with class property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to delete l.5 to pass the Linter test (done). Otherwise all good so far.
@dirkf Thank you for the linter fix! So, should I provide additional code for the generic extractor to at least find the |
Up to you, really. |
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I came across same company websites that provided videos via video-cdn.net, e.g. this. Some more can be found with the help of Google. The PR adds an extractor for those videos.