Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for oreilly login with new url #31524

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion youtube_dl/extractor/safari.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ def _login(self):
'Downloading login page')

def is_logged(urlh):
return 'learning.oreilly.com/home/' in urlh.geturl()
url = urlh.geturl()
parsed_url = compat_urlparse.urlparse(url)
return parsed_url.hostname.endswith('learning.oreilly.com') and (
parsed_url.path.startswith('/home/')
or (parsed_url.path == '/member/login/' and not parsed_url.query))

if is_logged(urlh):
self.LOGGED_IN = True
Expand Down