Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kick extractor #31576

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add Kick extractor #31576

wants to merge 13 commits into from

Conversation

jamilkarami
Copy link

@jamilkarami jamilkarami commented Feb 18, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adding support for Kick.com (Resolves #31430 )

@jamilkarami jamilkarami changed the title Add Kick Add Kick extractor Feb 18, 2023
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I've made a few suggestions: have a look.

youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Show resolved Hide resolved
youtube_dl/extractor/kick.py Show resolved Hide resolved
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. The tests seem to be OK.

I wonder if the data['source'] will ever not be a manifest URL. Presumably not if we're getting data from a field called livestream.

youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
youtube_dl/extractor/kick.py Outdated Show resolved Hide resolved
@dirkf
Copy link
Contributor

dirkf commented Apr 10, 2023

Please check against yt-dlp/yt-dlp#6748.

@jamilkarami
Copy link
Author

Please check against yt-dlp/yt-dlp#6748.

Seems to be working on my side

image
image

@aaron-tan
Copy link
Contributor

aaron-tan commented Aug 8, 2023

Tried to test using this video: https://kick.com/video/e466d965-b67d-471d-bed5-e3d4f19a4a9d but unfortunately it returned HTTP 403: forbidden error. The extractor is not working for me.

I've had a look at yt-dlp/yt-dlp#6748 and it seems to be an issue with cloudflare fingerprinting. I've tried the solutions offered like using my browser's user-agent string: python -m youtube_dl -v --user-agent ''USER AGENT'' https://kick.com/video/56292fc4-98fe-4fc8-8267-8082651bde12 but unfortunately it did not work for me. I've tried passing cookies from browser but there is no --cookies-from-browser option in youtube-dl (a new feature for the future maybe?) but no success it still returns HTTP 403: forbidden error.

@mccarreon mccarreon mentioned this pull request Jan 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kick support
3 participants