New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GooglePhotosIE from tokune/youtube-dl #31640
base: master
Are you sure you want to change the base?
Conversation
I also would wish to have a list of extractors that have been removed due to the site being shut down. I will plan on slowly but surely, porting every feature from that branch to the main youtube-dl, or someone else that has the git program can, as I do not have access to the command line at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There are some issues to consider. Let me know what you think.
|
||
|
||
class GooglePhotosIE(InfoExtractor): | ||
_VALID_URL = r'https?://photos\.google\.com/share/(.+?)/photo/(.+?)key=(?P<id>.*)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the key
not [\da-zA-Z]+
rather than .*
? Maybe -
is allowed, so [\da-zA-Z-]+
if so.
from .common import InfoExtractor | ||
|
||
|
||
class GooglePhotosIE(InfoExtractor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be merged with GoogleDriveIE
in youtube_dl/extractor/googledrive.py
? There seems to be a lot of commonality.
Co-authored-by: dirkf <fieldhouse@gmx.net>
thanks again Co-authored-by: dirkf <fieldhouse@gmx.net>
Co-authored-by: dirkf <fieldhouse@gmx.net>
Note to self: There is more info to extract, try and extract it? |
Let's merge |
Since I have access to cmd, I just ran a git diff, and the only difference was that Tokune's branch has Google Photos IE |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://github.com/tokune/youtube-dl
#13889 (comment)
What is the purpose of your pull request?
Description of your pull request and other information
Fixes #13889 . Due to tokune's youtube-dl fork being taken down back in 2020, when the "DMCA incident" occurred, I used the SoftwareHeritige archive of it. Thank you Tokune for creating the extractor itself and SoftwareHeritage for archiving GitHub repositories without any cost to access them.