Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[senateisvp] Updated senateisvp extractor to support new manifest urls #32027

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jsmnhou
Copy link

@jsmnhou jsmnhou commented Apr 11, 2023

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The senate.gov extractor has been broken as per #31373. This is because the locations of the m3u8 files had been moved to different URLs, and the format of these URLs have also changed. The extraction of these formats can be found here.

Note: This is a continuation of this pull request.

Depending on the video, there are four possible locations for the m3u8 to be located at:

The above parameters are found in the following places:

  • committee, filename - query parameters in the URL
  • stream_number, stream_domain, stream_id, msl3 - a js table variable called streamInfo which has been hardcoded as a python list in senateisvp.py

The new extractor will grab the parameters from the url and the lookup table, then iterate through the possible locations for the m3u8, returning it and its information when found.

@jsmnhou
Copy link
Author

jsmnhou commented Aug 7, 2023

@dirkf, are there any changes I can make to speed up the pull request process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant