Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security problems and maintenance #32739

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josemgarciar
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

josemgarciar added 2 commits March 8, 2024 10:52
Co-authored-by: FernandoTC18 <FernandoTC18@users.noreply.github.com>
Changes for maintenance and protocols security problems
Co-authored-by: FernandoTC18 <FernandoTC18@users.noreply.github.com>
Maintenance and security problems
@dirkf
Copy link
Contributor

dirkf commented Mar 8, 2024

  1. Use the template
  2. The SSL processing is somewhat carefully designed to work with the best available options according to the Python implementation in use. Please review the SSL documentation for versions 2.6 up before proposing changes.

@dirkf dirkf marked this pull request as draft March 8, 2024 13:28
@@ -26,7 +26,7 @@ def _real_extract(self, url):
continue
container = fmt.get('container')
if container == 'hls':
formats.extend(fmt_url, video_id, 'mp4', m3u8_id='hls', fatal=False)
formats.extend([fmt_url, video_id, 'mp4'], m3u8_id='hls', fatal=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an actual bug; thanks for the hint:

Suggested change
formats.extend([fmt_url, video_id, 'mp4'], m3u8_id='hls', fatal=False)
formats.extend(self._extract_m3u8_formats(fmt_url, video_id, 'mp4', m3u8_id='hls', fatal=False))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants