Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoided potential type's mismatch #32751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

igeni
Copy link

@igeni igeni commented Mar 22, 2024

avoided potential type's mismatch during concatenation and remove redundant type's conversion

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Avoided potential type's mismatch during concatenation and remove redundant type's conversion

@dirkf
Copy link
Contributor

dirkf commented Mar 22, 2024

What problem is being solved here?

You can't use f'{x}{y}' since the code should be able to run on versions of Python that treat that as a syntax error. If such a change should be needed, you would have to use '{0}{1}'.format(x, y). Apparently that would be OK here but elsewhere the code enables unicode_literals, with which the '...'.format(...) code would incorrectly generate a unicode value instead of a str in Python2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants