Facebook info extractor

[imrehg]

This is the first attempt on a FB info extractor. Tried to follow the other examples as close as possible.

Unfortunately I had to add one more import, if you know a way to unescape unicode-escaped strings (needed to extract video urls) with the current modules, I'd be glad to change it.

I'm also glad to have any other suggestions, I'm pretty sure you have advice in case I overcomplicated something (again).

[rg3]

Hi,

Sorry for taking so long to answer. I've been a bit busy this week. The code looks good and no doubt I'll merge it as long as you commit to support the InfoExtractor. It seems to integrate very well with the existing code. I'll make a few comments so you can address possible issues.

It prints "Facebook" with a capital F. Normally we print the name all in lowercase, so you could change that if you are going to make more changes. It's a minor detail.

Second, there is a block of code in the InfoExtractor indented with 4 spaces instead of tabs. You could probably use tabs to be consistent with the rest of the code.

In that same loop, line 2394, you use the word "format" as a variable name. "format" is a reserved word in some Python versions and, while you can assign another value to it, it's dangerous because we could add code that uses it later and it wouldn't work.

http://docs.python.org/library/functions.html#format

Finally, I don't mind importing more modules if they allow for doing something easily, as long as the modules are available in Python 2.5. My worry here is that the function you're using, unicode_escape_decode, is not mentioned in the documentation. Could you investigate this a little bit? If you explain me what it's supposed to do with an example, maybe we can code a safer version of that routine.

Best regards.