[funimation] Add new extractor #7767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import re | ||
|
|
||
| class FunimationBaseIE(InfoExtractor): |
There was a problem hiding this comment.
There's no need to create a base class if there's only one derived class.
There was a problem hiding this comment.
What's the purpose of the base class if it's only inherited once?
|
Commits should be squashed to a single commit. |
| except ExtractorError as e: | ||
| if isinstance(e.cause, compat_HTTPError) and e.cause.code == 403: | ||
| raise ExtractorError('%s is not available in your region.' % self.IE_NAME, expected=True) | ||
|
|
There was a problem hiding this comment.
You don't check whether login succeeded or not.
There was a problem hiding this comment.
Alright, fixed both. Now, how could I do this squashing? I am doing everything from web expect testing locally.
There was a problem hiding this comment.
You should consult some git manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.