[madmoizelle] Add new extractor #8507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtube_dl/extractor/madmoizelle.py
Outdated
| ) | ||
| ======= | ||
| from ..utils import HEADRequest | ||
| >>>>>>> 7a50899fde5f12ad3f44bd92141a1161a139f0ee |
There was a problem hiding this comment.
Leftovers from a merge. (Also force push, don't make new PRs)
youtube_dl/extractor/madmoizelle.py
Outdated
| for format in re.finditer('jwplayer.*"(?P<url>[0-9]+.*(?P<quality>hd|sd).+)"', webpage): | ||
| url = 'https://player.vimeo.com/external/' + format.group('url') | ||
|
|
||
| # the url found point to a header redirection that we must follow |
There was a problem hiding this comment.
What's the point? Let downloader follow it when downloading happens.
|
Multiple videos may be embedded: http://www.madmoizelle.com/apocalypse-verdun-502961#gs.s5Ztwk0. |
youtube_dl/extractor/wat.py
Outdated
| 'upload_date': upload_date, | ||
| 'duration': first_file['duration'], | ||
| 'formats': formats, | ||
| } |
There was a problem hiding this comment.
I guess this was deleted by a mistake.
|
Since #8497 landed, please move changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issues #6491