Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[myspace] Added support for downloading all songs of an artist #9295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AllanDaemon
Copy link

@AllanDaemon AllanDaemon commented Apr 24, 2016

With this, you can download all music from a artist page songs, including the ones outside an album.

_VALID_URL = r'https?://myspace\.com/(?P<artist>[^/]*)/music/songs'

_TESTS = [{
'url': 'https://myspace.com/starset2/music/album/transmissions-19455773',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

@AllanDaemon
Copy link
Author

Hi, is something else needed in order to accept the pull request?

@JohnKacz
Copy link

Checking on this?

@AllanDaemon
Copy link
Author

I closed accidentally.

@AllanDaemon AllanDaemon reopened this Dec 3, 2020
@AllanDaemon AllanDaemon closed this Dec 3, 2020
@AllanDaemon AllanDaemon reopened this Dec 3, 2020
@AllanDaemon
Copy link
Author

Is there anything else needed to merge this request?

@ytdl-org ytdl-org deleted a comment from liamengland1 May 4, 2021
@dstftw
Copy link
Collaborator

dstftw commented May 4, 2021

I've already pointed out what should be fixed to get this accepted.

@ytdl-org ytdl-org deleted a comment from AllanDaemon May 4, 2021
@ytdl-org ytdl-org deleted a comment from AllanDaemon May 4, 2021
@ytdl-org ytdl-org deleted a comment from AllanDaemon May 4, 2021
@ytdl-org ytdl-org deleted a comment from AllanDaemon May 4, 2021
@ytdl-org ytdl-org deleted a comment from AllanDaemon May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants