-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🐛 Add Scobble percent & Fix Last.fm login #1286
✨🐛 Add Scobble percent & Fix Last.fm login #1286
Conversation
jaredcat
commented
Feb 6, 2024
•
edited
Loading
edited
- fixes login for lastfm
- add user selectable scrobble percentage ([Feature Request] Last.fm scrobble percentage setting #533)
6aedb5f
to
91b18d2
Compare
Only skimmed though the PR currently. But why the change to 5 minutes when the documentation for Last.fm specifically notes 4 minutes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this as comments for now until I can test and verify the Authenicate thing.
The Ability to have the progress of the feature looks perfect and it's a lot simplier than I originally expected it to be, but some of the changes break L.fm's documentation / seem a step back.
db1f306
to
d7fcccb
Compare
dcf5d4f
to
c27f46d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primarily changes for the settings to make the UI look more consistent with the rest of stuff.
I will get this downloaded + tested tomorrow to see about the session stuff and the feature works as expected.
But otherwise this is looking good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final change for the .vscode/settings.json
file. And otherwise this is looking good, and should make it for the v2.0.1 release.
4337553
to
3f1f123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good :)