Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic column data #160

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brittonsmith
Copy link
Collaborator

PR Summary

This PR is in response to Issue #159. This adds support for loading merger trees from generic ascii files that minimally define a unique id and descendent id for each halo. Data needs to have the following attributes to be loaded:

  • data in a single ascii file ending in .col with a row for each halo
  • a three line header (each line starting with "#") defining field names, data types, and units.

For example, something like the following:

# uid, desc_uid, mass, redshift
# int, int, float, float
# None, None, Msun, None
1457223360,-1,1.023166e+12,0.000000e+00
1452164856,1457223360,3.164029e+11,1.019287e-02
1447024182,1452164856,1.913669e+11,2.050185e-02
1441813042,1447024182,1.929496e+11,3.090656e-02

@PauCaBu, please give this a try and let me know what you think. I would be happy to iterate on this with you.

PR Checklist

  • Code passes tests.
  • New features are documented with docstrings and narrative docs.
  • Tests added for fixed bugs or new features.

@brittonsmith brittonsmith added enhancement frontends issues and PRs related to a specific frontend labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement frontends issues and PRs related to a specific frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant