Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename operations archive #116

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Rename operations archive #116

merged 5 commits into from
Apr 2, 2024

Conversation

omgronny
Copy link
Contributor

@omgronny omgronny commented Feb 8, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

pkg/components/scheduler.go Outdated Show resolved Hide resolved
pkg/components/scheduler.go Outdated Show resolved Hide resolved
@l0kix2
Copy link
Collaborator

l0kix2 commented Feb 8, 2024

Also please check the test run https://github.com/ytsaurus/yt-k8s-operator/actions/runs/7829875497/job/21362727551?pr=116 — there are syntax errors.

Copy link
Collaborator

@l0kix2 l0kix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that took so long, I missed that commits were added.

Looks good, could you please rebase on main branch and resolve conflict (I suppose it is scheduler > Scheduler rename)?

@omgronny
Copy link
Contributor Author

Looks good, could you please rebase on main branch and resolve conflict (I suppose it is scheduler > Scheduler rename)?

Done

@omgronny omgronny closed this Mar 28, 2024
@omgronny omgronny reopened this Mar 28, 2024
@l0kix2
Copy link
Collaborator

l0kix2 commented Mar 28, 2024

one of e2es is failing, there is a chance that script is broken somehow

@omgronny
Copy link
Contributor Author

one of e2es is failing, there is a chance that script is broken somehow

Actually, the tests were green until I accidentally closed and reopened PR. Is it possible we have some flaps?

@l0kix2
Copy link
Collaborator

l0kix2 commented Mar 28, 2024

one of e2es is failing, there is a chance that script is broken somehow

Actually, the tests were green until I accidentally closed and reopened PR. Is it possible we have some flaps?

i've restarted them, let's see if the issue stays.

@l0kix2
Copy link
Collaborator

l0kix2 commented Apr 2, 2024

It may be unrelated (though persistent) flap, will look into that and merge after investigation.

@l0kix2 l0kix2 self-assigned this Apr 2, 2024
@l0kix2 l0kix2 merged commit 5d79c1c into ytsaurus:main Apr 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants