-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for solomon exporter: specify host and some instance tags #258
Conversation
Makefile
Outdated
@@ -33,7 +33,7 @@ else | |||
DOCKER_BUILD_ARGS += --build-arg VERSION="$(OPERATOR_TAG)" | |||
endif | |||
DOCKER_BUILD_ARGS += --build-arg REVISION="$(shell git rev-parse HEAD)" | |||
DOCKER_BUILD_ARGS += --build-arg BUILD_DATE="$(shell date --rfc-3339=seconds)" | |||
DOCKER_BUILD_ARGS += --build-arg BUILD_DATE="$(shell date -Iseconds)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, moved here: #260.
pkg/ytconfig/canondata/TestGetControllerAgentsConfig/test.canondata
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a unit-test right as you described in the PR description - start a cluster, make a http request to /solomon/all, make sure hostnames are there.
e2760b5
to
5ea87bf
Compare
LGTM, let's merge if @zlobober ok with the added test. |
…e tags (ytsaurus#258) * Add configuration for solomon exporter: specify host and some instance tags * Address comments
When the solomon_exporter section is not configured metrics are exported without any host-related labels, which isn't very convenient.
Tested locally that the sensors from
curl localhost:<monitoring_port>/solomon/all
are now enriched with the added attributes.