Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel in qt config #273

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

Krisha11
Copy link
Collaborator

@Krisha11 Krisha11 commented Jun 3, 2024

No description provided.

@Krisha11 Krisha11 requested a review from Krock21 June 3, 2024 09:06
Copy link
Member

@Krock21 Krock21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it manually?
It would be nice to get a unit test for it

@Krisha11 Krisha11 force-pushed the mpereskokova/add-channel-in-qt-config branch from 3cbcf12 to 16538d3 Compare June 7, 2024 13:11
@Krisha11
Copy link
Collaborator Author

Krisha11 commented Jun 7, 2024

Did you test it manually? It would be nice to get a unit test for it

Tested manually. E2e test added

@Krisha11 Krisha11 requested a review from Krock21 June 7, 2024 15:14
Copy link
Member

@Krock21 Krock21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get approvals from owners too (@l0kix2 @savnadya)

@Krisha11 Krisha11 requested review from l0kix2 and savnadya June 7, 2024 15:25
@l0kix2 l0kix2 merged commit 2d657b1 into main Jun 7, 2024
5 checks passed
@l0kix2 l0kix2 deleted the mpereskokova/add-channel-in-qt-config branch June 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants