Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of HTML escaping #151

Merged
merged 2 commits into from Dec 16, 2017
Merged

Correction of HTML escaping #151

merged 2 commits into from Dec 16, 2017

Conversation

denngie
Copy link
Contributor

@denngie denngie commented Dec 16, 2017

Fixes #103
Found the solution here

@laf laf merged commit c6dce0f into ytti:master Dec 16, 2017
@laf
Copy link
Contributor

laf commented Dec 16, 2017

thanks very much for submitting the fix @denngie

@denngie denngie deleted the fix-103 branch December 17, 2017 08:35
@pv2b
Copy link

pv2b commented Dec 18, 2017

Hi

I reviewed this fix and after reading what escape_once does it didn't really make sense that it would work correctly. However, once I actually put some test data through the system it seems to do the right thing in all cases I can figure out.

I then tried removing escape_once and just outputting the line without any escaping, and it seem that HAML already does escaping implicitly.

Probably escape_once can be removed completely to make the template cleaner, but I don't think the extra call actually hurts.

@denngie
Copy link
Contributor Author

denngie commented Dec 19, 2017

I'm a bit embarrassed that I never tried without it, but you are correct! I guess #114 would reappear though if we removed it since adding :escaped solved that issue. I don't have any nodes with xml output to test with

@nickhilliard
Copy link
Contributor

any chance of bumping the release version on oxidized-web to 0.9.4 because of this fix? This bug is super annoying.

@FlorianB06
Copy link

Hi guys, looking forward to a fix as this is an serious issue as copy / paste is not working because of this. Thaks a lot for your fantastic work

@mattie47
Copy link

mattie47 commented Apr 4, 2018

@laf - Can we look at bumping to 0.9.4 for this fix?

I think it's come up on https://community.librenms.org/t/oxidized-configs-quotes-marks-showing-as-quot/1735 as well.

Thanks,

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants