Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comtrol model #1507

Merged
merged 7 commits into from Sep 13, 2018
Merged

Add comtrol model #1507

merged 7 commits into from Sep 13, 2018

Conversation

RobbFromIT
Copy link
Contributor

@RobbFromIT RobbFromIT commented Sep 7, 2018

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

@wk
Copy link
Contributor

wk commented Sep 12, 2018

This looks good! This PR looks almost ready to go, but please consider adding a line to CHANGELOG.md taking credit for this contribution (if you'd like!) as well as adding the model into the docs/Supported-OS-Types.md file so that other users can discover it.

@RobbFromIT
Copy link
Contributor Author

Sounds great. I will get those added. Thanks!

@codecov-io
Copy link

codecov-io commented Sep 13, 2018

Codecov Report

Merging #1507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1507   +/-   ##
======================================
  Coverage    62.6%   62.6%           
======================================
  Files          30      30           
  Lines        1487    1487           
======================================
  Hits          931     931           
  Misses        556     556

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef48dbf...d31e58f. Read the comment docs.

@wk wk merged commit b64def6 into ytti:master Sep 13, 2018
@wk
Copy link
Contributor

wk commented Sep 13, 2018

Reshuffled the line order in CHANGELOG.md and merged. Thanks for sending this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants