Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterasys 800 series switches #2106

Merged
merged 3 commits into from May 27, 2020
Merged

Enterasys 800 series switches #2106

merged 3 commits into from May 27, 2020

Conversation

javichumellamo
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Add support for Enterasys series 800 switches

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #2106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4e05b...15ead6d. Read the comment docs.

@wk
Copy link
Contributor

wk commented May 21, 2020

This looks good! It would require a couple finishing touches before the PR can be pulled in:

  • model file renamed to lib/oxidized/models/entrasys800.rb, currently entrasys800
  • model link added to docs/Supported-OS-Types.md so users can discover support
  • model inclusion mentioned in CHANGELOG.md

Users can also be helped with a note in this PR (as a comment), in a comment in the model file itself, or in model notes describing which version of firmware and model of equipment this model was tested against (output of show version or similar).

@wk
Copy link
Contributor

wk commented May 24, 2020

I've made minor fix-ups to the PR itself that put everything in its right place and updated the documentation; if you could confirm this looks (and works) correctly, it should be ready to pull in.

Copy link
Contributor Author

@javichumellamo javichumellamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine

@wk wk merged commit f9d3715 into ytti:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants