Update xos.rb prompt to work with stacked switches #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current xos.rb regexp for prompt does not take stacked switches into account and therefore only works for standalone devices. This is a slight update to make the prompt regexp include stacked switches. Reference: ytti#2107 This update also fixes an issue that wasn't entirely solved in the previous pull request for xos.rb where Oxidized can't match the prompt if the XOS-device has not saved its configuration. Reference: ytti#2113
Codecov Report
@@ Coverage Diff @@
## master #2117 +/- ##
=======================================
Coverage 63.32% 63.32%
=======================================
Files 30 30
Lines 1497 1497
=======================================
Hits 948 948
Misses 549 549 Continue to review full report at Codecov.
|
This was referenced Jun 11, 2020
|
When will there be a release that includes this? It's been about seven months since this was fixed, and have over 500 switch stacks that can't be backed up without it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current xos.rb regexp for prompt does not take stacked switches into account and therefore only works for standalone devices. This is a slight update to make the prompt regexp include stacked switches.
Reference: #2107
This update also fixes an issue that wasn't entirely solved in the previous pull request for xos.rb where Oxidized can't match the prompt if the XOS-device has not saved its configuration.
Reference: #2113
Pre-Request Checklist
rubocop --auto-correct)rake test)Description