Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ironware.rb: Fix "current speed" regex to enclude MED-HI speed #2155

Merged
merged 2 commits into from Jul 25, 2020

Conversation

michaelpsomiadis
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

The following line output by show chassis was not accounting for all cases, which meant configuration would be updated based on fan speed.

-! --- TEMPERATURE are in auto mode (current speed is MED-HI (90%)). Temperature monitoring poll period is 60 seconds.

Added '-' character to regex to resolve issue.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #2155 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2155   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab6c58...b02c315. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jul 25, 2020

Thanks! Pulling this in.

@wk wk merged commit 48d8d87 into ytti:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants