Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNMP community removal for Netgear #2168

Merged
merged 2 commits into from Aug 15, 2020
Merged

Fix SNMP community removal for Netgear #2168

merged 2 commits into from Aug 15, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Aug 5, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Before:

snmp-server community <hidden>
snmp-server community <hidden> 192.168.0.100 public
snmp-server community <hidden> 255.255.255.255 public

After:

snmp-server community <hidden>
snmp-server community ipaddr 192.168.0.100 <hidden>
snmp-server community ipmask 255.255.255.255 <hidden>

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #2168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2168   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d8d87...1895976. Read the comment docs.

@wk
Copy link
Contributor

wk commented Aug 15, 2020

Thank you! Merging this.

@wk wk merged commit 61d9737 into ytti:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants