Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for NEC IX devices. #2409

Merged
merged 1 commit into from Nov 30, 2021
Merged

Adds support for NEC IX devices. #2409

merged 1 commit into from Nov 30, 2021

Conversation

mikenowak
Copy link
Contributor

@mikenowak mikenowak commented Nov 28, 2021

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test) N/A I beleive
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Adds support for NEC IX devices.

@mortzu
Copy link
Collaborator

mortzu commented Nov 30, 2021

Can you complete the checklist, please?

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #2409 (a3253a4) into master (8179f48) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
- Coverage   62.59%   62.45%   -0.14%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
- Hits          937      935       -2     
- Misses        560      562       +2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8179f48...a3253a4. Read the comment docs.

@mikenowak
Copy link
Contributor Author

I've updated the checklist and the model based on rubocop --auto-correct.

As for rake test, I don't believe these apply to models.

@mortzu mortzu merged commit 6d78776 into ytti:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants