Rubocop fixes #2476
Merged
Rubocop fixes #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
- Coverage 63.28% 63.23% -0.06%
==========================================
Files 30 30
Lines 1498 1504 +6
==========================================
+ Hits 948 951 +3
- Misses 550 553 +3
Continue to review full report at Codecov.
|
mjbnz
force-pushed
the
rubocop-fixes
branch
2 times, most recently
from
8b5892f
to
ad56176
Compare
mjbnz
referenced
this pull request
Feb 10, 2022
…information as comment. (#2377) * OPNsense/PFsense models: Do not cut off first line This model was mistakenly removing the first line of the config file containing the <?xml line. * PFsense/OPNsense: Add feature to gather version information as a comment at the end of the file * Move xmlcomment into model.rb * Changelog for OPNsense/PFsense changes/fixes
4 tasks
Reduces Cyclomatic and Percieved complexity Signed-off-by: Mike Beattie <mike@ethernal.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct) (@mjbnz: sort of ?)- [ ] Tests added or adapted (tryN/Arake test)- [ ] Changes are reflected in the documentationN/A.- [ ] User-visible changes appended to CHANGELOG.mdN/ADescription
Clean up a few rubocop offences reported by the Travis Pull Request checks.
Fixed ssh_make_opts by breaking out the proxy command generation to a separate function.