Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP Mail sending in docker container and documentation for sending mail with msmtp #2809

Merged
merged 10 commits into from Jul 4, 2023

Conversation

Krafting
Copy link
Contributor

@Krafting Krafting commented May 24, 2023

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Added the package msmtp to the docker container to add the ability to send mail using SMTP when using hooks and docker, also added relevent documentation.

I'm not that happy with the whole symlink from .config/oxidized to the homedir for the .msmtprc file, but having config all in the same place is easier to manage and it does work.

Please give feedback!

Documentation might also be badly worded or not understandable enough, feel free to give me feedback.

Thanks everyone involved in this project!

Closes issue #2574

Depends on PR #2813 (Fixes #2769)

@electrocret
Copy link
Contributor

electrocret commented Jun 14, 2023

I don't believe PR #2813 is absolutely needed (Of course it couldn't hurt). I was able to get my container, which is running latest, to send failed backup emails using the changes in this PR.

@Krafting
Copy link
Contributor Author

I don't believe PR #2813 is absolutely needed (Of course it couldn't hurt). I was able to get my container, which is running latest, to send failed backup emails using the changes in this PR.

Maybe it changed since I last tested it, will need to retry.

Also, if you have any feedback, especially about the documentation and the whole process to add mail notification it would help a lot!

@electrocret
Copy link
Contributor

electrocret commented Jun 16, 2023

Nah, it was extremely straightforward what I did. I executed all the new commands in the Dockerfile on my existing container running the latest oxidized, then added the documented lines to my config. The only part where I had to do a little bit of troubleshooting was getting msmtp configured correctly. So maybe add a link to an msmtp guide? However that's really out of scope of Oxidized.

I also think I'm not affected by #2813, cause I haven't noticed it in my logs despite running 0.29.1.

On an tangentially related topic - I had to disable this cause we had more nodes failing than we thought and it was spamming us, but still not an oxidized issue, it's a node config issue. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading config: undefined method `unsafe_load' for Psych:Module
3 participants