Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SCP input script #2919

Merged
merged 2 commits into from Oct 30, 2023
Merged

add SCP input script #2919

merged 2 commits into from Oct 30, 2023

Conversation

aeiodelic
Copy link
Contributor

@aeiodelic aeiodelic commented Aug 23, 2023

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Needed for some, mainly old, devices that only support backup over SCP.

Solves issue 1802 that was already closed due to not planned.

@github-actions github-actions bot added the Stale label Oct 23, 2023
@github-actions github-actions bot closed this Oct 30, 2023
@aschaber1
Copy link
Collaborator

This looks like an interesting extension. I'm going to reopen this :)

Hopefully maybe one of my co-maintainers with more ruby experience have an opinion on this.

@aschaber1 aschaber1 reopened this Oct 30, 2023
@aeiodelic
Copy link
Contributor Author

This looks like an interesting extension. I'm going to reopen this :)

Hopefully maybe one of my co-maintainers with more ruby experience have an opinion on this.

Thanks. We have this running in our company to backup Fortigate devices by SCP. It has been requested in the issue quoted in the description so I am sure that it must be interesting for at least some people.

@ytti
Copy link
Owner

ytti commented Oct 30, 2023

I think it is fine basically regardless of its condition, because it doesn't affect anything existing, so there is no real other pressure than 'does it help someone', which is satisfied.

@aschaber1 aschaber1 merged commit 8677c61 into ytti:master Oct 30, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants