Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digest HTTP Authentication with Basic Auth Fallback #3074

Merged
merged 1 commit into from Feb 19, 2024

Conversation

derhelge
Copy link
Contributor

Description

This patch introduces the ability to perform Digest HTTP authentication when making requests. If Digest authentication is not required or fails, the method falls back to Basic authentication. This enhancement provides more flexibility in handling different authentication schemes and improves compatibility with various systems.

Fixes #2685.

@ytti ytti merged commit e59b50f into ytti:master Feb 19, 2024
@derhelge derhelge deleted the http-digest-auth branch February 19, 2024 09:30
@derhelge
Copy link
Contributor Author

Hi @ytti thanks for accepting the pull request. Unfortunately i introduced a bug:
Line 60 in http.rb should be:
if res.code == '401' && res['www-authenticate']&.include?('Digest')
Elsewhat basic auth stops working because res['www-authenticate'] is nil. Sorry

@ytti
Copy link
Owner

ytti commented Feb 19, 2024

Submit new PR for the safe navigation, no problem.

@robertcheramy
Copy link
Collaborator

This PR introduced RuboCop Warnings (Layout/TrailingWhitespace).
The GitHub checks did not run (I don't know why), so it could not easily been seen.
These warnings will be fixed with PR #3079.

@derhelge
Copy link
Contributor Author

Thanks @robertcheramy
I apologize that you had extra work due to my inability. I am not a Ruby developer and am still learning how to use oxidized dev-wise.

@robertcheramy
Copy link
Collaborator

@derhelge - no problem. Thank you for contributing to oxidized!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwOS model not working due to HTTP Digest
3 participants