Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong regexp to get ride of \r #3108

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

robertcheramy
Copy link
Collaborator

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Closes #2997

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.49%. Comparing base (50bae60) to head (273b755).

Files Patch % Lines
lib/oxidized/input/ssh.rb 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   65.49%   65.49%           
=======================================
  Files          34       34           
  Lines        1649     1649           
=======================================
  Hits         1080     1080           
  Misses        569      569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertcheramy robertcheramy merged commit 44b09d1 into ytti:master Mar 18, 2024
6 of 7 checks passed
@robertcheramy robertcheramy deleted the 2997-asa-context branch March 18, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not pulling Cisco ASA contexts
2 participants