fix repository path resolution #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2016 06:57
this correctly respects the repo declaration as Hash or String
apart from the refactorings, now the node path its correct even when groups are used
|
Thanks. Seems like non-trivial amount of work. Bit worried about removal of locking, but can't justify the need for it either. |
I haven't removed it, still here 馃憠 lib/oxidized/nodes.rb#L169-L176 馃槈 |
|
Aah my bad. I don't really know if we actually even need it, I'm not sure. I guess better safe than sorry. |
This was referenced Aug 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was missing the option for when using groups and defining the repository as a
String(like, fordefaultgroup).This should (hopefully) fix some issues, like #473, #497, #334 馃槃