Add .pre-commit-config.yaml (#78)

* Add `.pre-commit-config.yaml`

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>

* Update

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>

* Update

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>

* test

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>

---------

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>

.pre-commit-config.yaml

@@ -0,0 +1,15 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.4.0
+    hooks:
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+      - id: check-yaml
+  - repo: https://github.com/rhysd/actionlint
+    rev: main
+    hooks:
+      - id: actionlint
+  - repo: https://github.com/hadolint/hadolint
+    rev: v2.12.0
+    hooks:
+      - id: hadolint

Dockerfile

@@ -1,6 +1,6 @@
 FROM python:3.9-slim
 
-ENV REVIEWDOG_VERSION="v0.13.0"
+ENV REVIEWDOG_VERSION="v0.14.1"
 
 ENV WORKING_DIRECTORY="/workdir"
 WORKDIR "$WORKING_DIRECTORY"

Makefile

@@ -1,2 +1,14 @@
 setup-dev:
-	SQLFLUFF_VERSION=1.2.0 pip install -r requirements/requirements.txt
+	SQLFLUFF_VERSION=1.2.0 pip install --force-reinstall -r requirements/requirements.txt
+	pre-commit install
+
+lint: lint-shell lint-json lint-docker
+
+lint-shell:
+	shellcheck entrypoint.sh
+
+lint-json:
+	cat "to-rdjson.jq" | jq empty > /dev/null 2>&1; echo "$?"
+
+lint-docker:
+	hadolint Dockerfile

requirements/requirements.txt

@@ -1,8 +1,11 @@
-sqlfluff==${SQLFLUFF_VERSION}
-sqlfluff-templater-dbt==${SQLFLUFF_VERSION}
+setuptools>=65.5.1
+pre-commit==2.15.0
 
 # `CompilationException` is no longer implemented from dbt-core==1.4.0.
 # So we have to use dbt-core 1.3 or less, until the subsequent fix is released.
 # SEE https://github.com/sqlfluff/sqlfluff/pull/4317
 dbt-core<1.4
-setuptools>=65.5.1 # not directly required, pinned by Snyk to avoid a vulnerability
+
+# sqlfluff
+sqlfluff==${SQLFLUFF_VERSION}
+sqlfluff-templater-dbt==${SQLFLUFF_VERSION}

testdata/test_failed_dbt/models/staging/staging_test.sql

@@ -2,5 +2,5 @@
 
 SELECT
   1 AS x,
-   2 AS y,
+    2 AS y,
   3 AS z