Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dbt 1.5 with sqlfluff 2.0 #85

Merged
merged 12 commits into from
May 2, 2023
Merged

Support dbt 1.5 with sqlfluff 2.0 #85

merged 12 commits into from
May 2, 2023

Conversation

yu-iskw
Copy link
Owner

@yu-iskw yu-iskw commented May 2, 2023

No description provided.

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
@yu-iskw yu-iskw marked this pull request as ready for review May 2, 2023 09:12
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

@@ -1,4 +1,4 @@
FROM python:3.9-slim
FROM python:3.10-slim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure healthcheck instructions have been added to container images
    Resource: /Dockerfile. | Bridgecrew ID: BC_DKR_2 | Checkov ID: CKV_DOCKER_2

Description

We recommend that you add the HEALTHCHECK instruction to your Docker container images to ensure that health checks are executed against running containers.

An important security control is that of availability. Adding the HEALTHCHECK instruction to your container image ensures that the Docker engine periodically checks the running container instances against that instruction to ensure that containers are still operational.

Based on the results of the health check, the Docker engine could terminate containers which are not responding correctly, and instantiate new ones.

Benchmarks

  • CIS DOCKER V1.2 4.6

@@ -2,3 +1,4 @@
FROM python:3.10-slim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure a user for the container has been created
    Resource: /Dockerfile. | Bridgecrew ID: BC_DKR_3 | Checkov ID: CKV_DOCKER_3

Description

Containers should run as a non-root user. It is good practice to run the container as a non-root user, where possible. This can be done either via the ```USER``` directive in the ```Dockerfile``` or through ```gosu``` or similar where used as part of the ```CMD``` or ```ENTRYPOINT``` directives.

Benchmarks

  • CIS DOCKER V1.2 4.1

Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
Signed-off-by: Yu ISHIKAWA <yuu.ishikawa+github@gmail.com>
@yu-iskw yu-iskw changed the title Support dbt 1.5 Support dbt 1.5 with sqlfluff 2.0.7 May 2, 2023
@yu-iskw yu-iskw changed the title Support dbt 1.5 with sqlfluff 2.0.7 Support dbt 1.5 with sqlfluff 2.0 May 2, 2023
@yu-iskw yu-iskw merged commit 2b313f1 into main May 2, 2023
39 of 41 checks passed
@yu-iskw yu-iskw deleted the support-dbt-1.5 branch May 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant