Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest v8 compatibility #25

Merged
merged 2 commits into from
Jan 31, 2023
Merged

add manifest v8 compatibility #25

merged 2 commits into from
Jan 31, 2023

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Jan 28, 2023

Closes #24

@dlawin dlawin requested a review from yu-iskw as a code owner January 28, 2023 01:24
@dlawin
Copy link
Contributor Author

dlawin commented Jan 28, 2023

Should i generate artifacts for jaffleshop? Wasn't sure how those were being created

@yu-iskw
Copy link
Owner

yu-iskw commented Jan 30, 2023

@dlawin Thank you for the contribution. I would like to add some unit tests, no matter how simple is. The jaffle_shop project would be good for unit tests at the modment.

@dlawin
Copy link
Contributor Author

dlawin commented Jan 30, 2023

@dlawin Thank you for the contribution. I would like to add some unit tests, no matter how simple is. The jaffle_shop project would be good for unit tests at the modment.

added

@@ -129,3 +129,6 @@ dmypy.json

# Pyre type checker
.pyre/

# VSCode
.vscode
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode
.vscode

@@ -15,7 +15,6 @@
# limitations under the License.
#
from typing import Union
from dbt_artifacts_parser.parsers.manifest.manifest_v7 import ManifestV7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reordering imports.

@yu-iskw yu-iskw merged commit 7bdf853 into yu-iskw:main Jan 31, 2023
@yu-iskw
Copy link
Owner

yu-iskw commented Jan 31, 2023

@dlawin Thank you for updating the parser together. I have merged it into the default branch.

@yu-iskw
Copy link
Owner

yu-iskw commented Jan 31, 2023

We have published v0.2.4. Can you give it a try on your use case?
https://github.com/yu-iskw/dbt-artifacts-parser/releases/tag/v0.2.4

@dlawin
Copy link
Contributor Author

dlawin commented Jan 31, 2023

We have published v0.2.4. Can you give it a try on your use case? https://github.com/yu-iskw/dbt-artifacts-parser/releases/tag/v0.2.4

Yes I can test in the next day or two!

@dlawin
Copy link
Contributor Author

dlawin commented Feb 1, 2023

We have published v0.2.4. Can you give it a try on your use case? https://github.com/yu-iskw/dbt-artifacts-parser/releases/tag/v0.2.4

works great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support v8 manifest
2 participants