-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add manifest v8 compatibility #25
Conversation
Should i generate artifacts for jaffleshop? Wasn't sure how those were being created |
@dlawin Thank you for the contribution. I would like to add some unit tests, no matter how simple is. The jaffle_shop project would be good for unit tests at the modment. |
added |
@@ -129,3 +129,6 @@ dmypy.json | |||
|
|||
# Pyre type checker | |||
.pyre/ | |||
|
|||
# VSCode | |||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.vscode | |
.vscode | |
@@ -15,7 +15,6 @@ | |||
# limitations under the License. | |||
# | |||
from typing import Union | |||
from dbt_artifacts_parser.parsers.manifest.manifest_v7 import ManifestV7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reordering imports.
@dlawin Thank you for updating the parser together. I have merged it into the default branch. |
We have published v0.2.4. Can you give it a try on your use case? |
Yes I can test in the next day or two! |
works great |
Closes #24