Add a 'ready' event #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasDup: Only called in getMessages() with result of Array#some, which makes an array. unique: Called in getMessages() with result of Array#filter, which makes an array. Called in watch() with a value that passed is.array() check. composeMessage: Called makeArray() on `names`, which is a private array that cannot be replaced by user code.
fs.readdir() either gives an error, or an array of values.
Other outcomes are not possible.
If we want to support that possibility, perhaps there should be
another `if` with `throw new Error('invalid fs.readdir value');`.
But, instead, I think maybe it should be removed.
This is fires once the watchers are created. * For single files, this happens immediately. * For directories on macOS/Windows (recursive, and non-recursive) this happens after hasNativeRecursive() callback. * For directories on Linux (non-recursive) this happens after hasNativeRecursive() callback. * For directories on Linux (recursive) this happens after hasNativeRecursive() callback and after each recursive call to watchDirectory() via getSubDirectories() is completed. To keep track of this, use a counting semaphore. Fixes yuanchuan#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71.