Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce valueGetter and valueSetter options #5

Merged
merged 1 commit into from
Apr 23, 2015
Merged

Introduce valueGetter and valueSetter options #5

merged 1 commit into from
Apr 23, 2015

Conversation

stefanoverna
Copy link
Contributor

I need to apply a typewriter effect to an input placeholder.. this generalization is perfectly backward compatible and makes the task trivial. Tests are all green!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0c659bb on stefanoverna:master into 7cffb2b on yuanqing:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0c659bb on stefanoverna:master into 7cffb2b on yuanqing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a343e6e on stefanoverna:master into 7cffb2b on yuanqing:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a343e6e on stefanoverna:master into 7cffb2b on yuanqing:master.

@zeke
Copy link
Collaborator

zeke commented Apr 23, 2015

whoa @coveralls.

@stefanoverna this looks interesting. I'm not the owner or maintainer of this repo, but an example in the readme explaining how to use malarkey with an input placeholder would be helpful. :)

@yuanqing
Copy link
Owner

@stefanoverna Thanks for this; merging

I'll be making some changes before cutting a release:

  1. Prefer getter and setter
  2. Add some tests with the two new opts
  3. Edit the README a bit

(Also, thanks @zeke!)

yuanqing pushed a commit that referenced this pull request Apr 23, 2015
Introduce valueGetter and valueSetter options
@yuanqing yuanqing merged commit 8588d90 into yuanqing:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants