Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work after activity has been recreated #55

Closed
schaal opened this issue Feb 4, 2017 · 1 comment
Closed

Doesn't work after activity has been recreated #55

schaal opened this issue Feb 4, 2017 · 1 comment

Comments

@schaal
Copy link

schaal commented Feb 4, 2017

The code list fragment doesn't get updated (no new codes appear) after the activity had to be recreated (e.g. due to OOM). The issue seems to lie in ListCodesFragment.kt:

    fun showCodes(codeMap: List<Map<String, String>>) {
        if (activity == null) {
            initialCodes = codeMap
            return
        }

activity is null here after it has been recreated and the function returns without updating the list. Seems the fragment doesn't get properly reattached to its Activity in this case.

@dainnilsson
Copy link
Member

This should be fixed in 1.2.0 (available from Github releases, being pushed out to the beta channel in the Play store, to be promoted to the stable channel in a few days if no issues are reported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants