Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add a fancy GitHub Action for 'shellcheck' #38

Merged
merged 1 commit into from
Jan 31, 2022
Merged

✨ add a fancy GitHub Action for 'shellcheck' #38

merged 1 commit into from
Jan 31, 2022

Conversation

thomasmerz
Copy link
Contributor

@thomasmerz thomasmerz commented Jan 30, 2022 •
edited

I have promised in #37 (comment) that I will make a PR for shellcheck - here we go 😁

@thomasmerz thomasmerz mentioned this pull request Jan 30, 2022
Merged
@thomasmerz
Copy link
Contributor Author

Here are my tests, so you can see what this action is doing and under which condition it is doing what: https://github.com/thomasmerz/pihole_adlist_tool/actions

image

@thomasmerz
Copy link
Contributor Author

An E-Mail will be sent in case of an error with link to the action that failed:
image

yubiuser
yubiuser reviewed Jan 31, 2022
View reviewed changes
Copy link
Owner

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. Only downside for me - I didn't learn how to do it myself ;-)

As written in the comments, I'd prefer to have it running in all pushes and branches.

shellcheck.yml Outdated Show resolved Hide resolved
shellcheck.yml Outdated Show resolved Hide resolved
shellcheck.yml Outdated Show resolved Hide resolved
@yubiuser
Copy link
Owner

From the documentation

You must store workflow files in the .github/workflows directory of your repository.

@thomasmerz
✨ add a fancy GitHub Action for 'shellcheck' when pushing to 'pihole_…
be67b59 
…adlist_tool' and for each PR to 'master' branch
@thomasmerz
Copy link
Contributor Author

@yubiuser , I adapted your recommendations in my commit/PR :)

@thomasmerz
Copy link
Contributor Author

Sorry, for "stealing" the fun 😉 But maybe you might have some fun by learning and showing me, how this should look like using the official docker-container from koalaman koalaman/shellcheck:stable as I showed you how this works on GitLab?!

@thomasmerz
Copy link
Contributor Author

You must store workflow files in the .github/workflows directory of your repository.

Funny that it even works/worked if workflow files are stored outside the .github/workflows directory 😜

@thomasmerz
Copy link
Contributor Author

You could/should also fix some repo-settings to benefit of the shellcheck action:

image

@yubiuser yubiuser changed the title ✨ add a fancy GitHub Action for 'shellcheck' when pushing to 'pihole_adlist_tool' and for each PR to 'master' branch ✨ add a fancy GitHub Action for 'shellcheck' Jan 31, 2022
@yubiuser yubiuser merged commit 890f454 into yubiuser:master Jan 31, 2022
@thomasmerz thomasmerz deleted the add_github_action branch January 31, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasmerz @yubiuser