Disallow empty parens (vektah#292).

yuchenshi · Apr 5, 2024 · 6acf555 · 6acf555
1 parent 591c98b
commit 6acf555
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 2 deletions.
diff --git a/parser/query.go b/parser/query.go
@@ -83,7 +83,7 @@ func (p *parser) parseOperationType() Operation {
 
 func (p *parser) parseVariableDefinitions() VariableDefinitionList {
 	var defs []*VariableDefinition
-	p.many(lexer.ParenL, lexer.ParenR, func() {
+	p.some(lexer.ParenL, lexer.ParenR, func() {
 		defs = append(defs, p.parseVariableDefinition())
 	})
 
@@ -167,7 +167,7 @@ func (p *parser) parseField() *Field {
 
 func (p *parser) parseArguments(isConst bool) ArgumentList {
 	var arguments ArgumentList
-	p.many(lexer.ParenL, lexer.ParenR, func() {
+	p.some(lexer.ParenL, lexer.ParenR, func() {
 		arguments = append(arguments, p.parseArgument(isConst))
 	})
 

diff --git a/validator/schema_test.yml b/validator/schema_test.yml
@@ -80,6 +80,15 @@ object types:
       message: 'Name "__id" must not begin with "__", which is reserved by GraphQL introspection.'
       locations: [{line: 2, column: 3}]
 
+  - name: field argument list must not be empty
+    input: |
+      type FooBar {
+        foo(): ID
+      }
+    error:
+      message: 'expected at least one definition, found )'
+      locations: [{line: 2, column: 7}]
+
   - name: check reserved names on type field argument
     input: |
       type FooBar {

diff --git a/validator/spec/EmptyParens.spec.yml b/validator/spec/EmptyParens.spec.yml
@@ -0,0 +1,26 @@
+- name: Empty variables list
+  schema: 0
+  query: |
+    query foo(){
+      dog {
+        __typename
+      }
+    }
+
+  errors:
+    - message: "expected at least one definition, found )"
+      locations:
+      - {line: 1, column: 11}
+- name: Empty arguments list
+  schema: 0
+  query: |
+    query foo{
+      dog() {
+        __typename
+      }
+    }
+
+  errors:
+    - message: "expected at least one definition, found )"
+      locations:
+      - {line: 2, column: 7}