Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make it into a prebuilt extension? #158

Open
hellojinwoo opened this issue Nov 4, 2021 · 3 comments
Open

Can you make it into a prebuilt extension? #158

hellojinwoo opened this issue Nov 4, 2021 · 3 comments

Comments

@hellojinwoo
Copy link

hellojinwoo commented Nov 4, 2021

The installation of source extensions jupyter labextension install is likely to be removed in future versions of JupyterLab: jupyterlab/jupyterlab#11336 . So the only way to install your theme would be a 'prebuilt extension'. Can you make your theme jupyterlab_city-lights-theme a prebuilt extension, please?

More information on a prebuilt extension can be found here

I would love to install your theme on jupyterlab desktop, but only prebuilt extensions are allowed to be installed there. So please make your city lights theme to the prebuilt extension.

@jtpio
Copy link

jtpio commented Nov 4, 2021

Hi,

Coming here from the issue on JupyterLab: jupyterlab/jupyterlab#11336

Although it's not decided if or when the managing of source extensions will be dropped, installing prebuilt extensions is still a nice improvement for the end users.

There is also a migration guide in the docs, and the python -m jupyterlab.upgrade_extension script should already help quite a bit with the migration: https://jupyterlab.readthedocs.io/en/stable/extension/extension_migration.html#jupyterlab-2-x-to-3-x

@hellojinwoo hellojinwoo changed the title Can you make it a prebuilt extension? Can you make it into a prebuilt extension? Nov 4, 2021
@yudai-nkt
Copy link
Owner

I once tried to support the prebuilt extension when JupyterLab 3.0 came out, and #100 is an attempt to prepare Python's venv setup prior to the actual implementation. As you can see in the PR, GitHub Actions somehow keeps failing in the topic branch whereas the equivalent test goes well on my local end. I gave up troubleshooting quite a while ago, but I try to make some time again to look into this.

I didn't know that jupyterlab/jupyterlab#11336 has been discussed. Thanks for letting me know!

@hellojinwoo
Copy link
Author

hellojinwoo commented Nov 7, 2021

For some applications, the only allowed way to install jupyter extensions is via 'pip' or 'conda' already. So the command jupytelab extension install does not work. One of the examples is the 'Jupyterlab Desktop'.

So hope this theme would be migrated to the prebuilt extensions successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants