Instantiate single YBClient instances for multiple methods #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have helper methods which take in the configuration and create a
YBClient
instance of their own to execute RPC calls. However, they may end up creating multiple instances ofYBClient
which may lead to a memory/file leak if they're not garbage collected on time.Another scenario where this could lead to a problem would be when heavily doing task/connector restarts as we will open a socket every time we create an instance of
YBClient
.Solution
This PR is a small step to mitigate the problem a little by reusing the
YBClient
instances wherever necessary.Additional notable changes in the PR:
YugabyteDBConnector#validateTserverConnection
debug
logs toinfo
as they were only being logged once.