Make GetChanges logging only at the DEBUG level
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumukh-Phalgaonkar
approved these changes
Nov 7, 2023
vaibhav-yb
changed the title
GetChanges logging configurableGetChanges logging only at the DEBUG level
vaibhav-yb
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The log line "Requesting changes from" is logged every time the connector makes an RPC call to get the changes from service. This, however, results in too many logs in the connector over a period of time and can be a bottleneck in terms of log size and logging costs.
Solution
This PR changes the log level to
DEBUG. If run without DEBUG logs, we will only log the line at an interval oflog.get.changes.interval.ms(default: 5601000) which will work as an indicator that the task has some activity going on.