[YSQL] Improve exception handling (YugaByte/yugabyte-db#938) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenspider
changed the title
frozenspider
changed the title
ttyusupov
requested changes
Jul 18, 2019
| #"(?i)This connection has been closed" | ||
| {:type :info, :error [:conn-closed m]} | ||
|
|
||
| ; Happens when there's a problem communicating with server |
There was a problem hiding this comment.
which server is meant here?
There was a problem hiding this comment.
Given that this is PG driver-level errors section, PG driver only communicates with tserver
There was a problem hiding this comment.
Then it is worth to make it clear in section description.
ttyusupov
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Done as a part of yugabyte/yugabyte-db#938)
teardowninwith-errorsto prevent it from failing the test