Don't throw an exception on rolling release Linux distributions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed on Arch Linux:
Traceback (most recent call last):
File "/home/deen/git/yugabyte-db/python/yb/thirdparty_tool.py", line 637, in <module>
main()
File "/home/deen/git/yugabyte-db/python/yb/thirdparty_tool.py", line 608, in main
thirdparty_release: Optional[MetadataItem] = get_third_party_release(
File "/home/deen/git/yugabyte-db/python/yb/thirdparty_tool.py", line 519, in get_third_party_release
os_type = local_sys_conf().short_os_name_and_version()
File "/home/deen/git/yugabyte-db/build/venv/lib/python3.10/site-packages/sys_detection/__init__.py", line 191, in short_os_name_and_version
return '%s%s' % (self.short_os_name(), self.short_os_version())
File "/home/deen/git/yugabyte-db/build/venv/lib/python3.10/site-packages/sys_detection/__init__.py", line 180, in short_os_version
version_id = self.linux_os_release.version_id
AttributeError: 'OsReleaseVars' object has no attribute 'version_id'
After the fix it still fails (as expected) but at least the error
message is friendlier:
[2022-03-16T14:27:43 yugabyte-bash-common.sh:149 detect_os] arch is not a supported Linux distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed on Arch Linux:
After the fix it still fails (as expected) but at least the error
message is friendlier: