-
Notifications
You must be signed in to change notification settings - Fork 1.1k
/
ql-transaction-test.cc
1382 lines (1167 loc) · 43.3 KB
/
ql-transaction-test.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
//
// Copyright (c) YugaByte, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
// in compliance with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software distributed under the License
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
// or implied. See the License for the specific language governing permissions and limitations
// under the License.
//
//
#include "yb/client/txn-test-base.h"
#include <boost/scope_exit.hpp>
#include "yb/client/transaction.h"
#include "yb/client/transaction_rpc.h"
#include "yb/consensus/consensus.h"
#include "yb/rpc/rpc.h"
#include "yb/tablet/tablet_peer.h"
#include "yb/tablet/transaction_coordinator.h"
#include "yb/tserver/mini_tablet_server.h"
#include "yb/tserver/tablet_server.h"
#include "yb/tserver/ts_tablet_manager.h"
#include "yb/tserver/tserver_service.pb.h"
#include "yb/util/random_util.h"
#include "yb/yql/cql/ql/util/errcodes.h"
#include "yb/yql/cql/ql/util/statement_result.h"
using namespace std::literals;
using yb::tablet::GetTransactionTimeout;
using yb::tablet::TabletPeer;
DECLARE_uint64(transaction_heartbeat_usec);
DECLARE_uint64(log_segment_size_bytes);
DECLARE_int32(log_min_seconds_to_retain);
DECLARE_uint64(max_clock_skew_usec);
DECLARE_bool(transaction_allow_rerequest_status_in_tests);
DECLARE_uint64(transaction_delay_status_reply_usec_in_tests);
DECLARE_bool(flush_rocksdb_on_shutdown);
DECLARE_bool(transaction_disable_proactive_cleanup_in_tests);
DECLARE_uint64(aborted_intent_cleanup_ms);
DECLARE_int32(remote_bootstrap_max_chunk_size);
DECLARE_int32(master_inject_latency_on_transactional_tablet_lookups_ms);
namespace yb {
namespace client {
class QLTransactionTest : public TransactionTestBase {
protected:
// We write data with first transaction then try to read it another one.
// If commit is true, then first transaction is committed and second should be restarted.
// Otherwise second transaction would see pending intents from first one and should not restart.
void TestReadRestart(bool commit = true);
void TestWriteConflicts(bool do_restarts);
IsolationLevel GetIsolationLevel() override {
return IsolationLevel::SNAPSHOT_ISOLATION;
}
CHECKED_STATUS WaitTransactionsCleaned() {
return WaitFor(
[this] { return CountTransactions() == 0; }, kTransactionApplyTime, "Transactions cleaned");
}
};
TEST_F(QLTransactionTest, Simple) {
WriteData();
VerifyData();
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, LookupTabletFailure) {
FLAGS_master_inject_latency_on_transactional_tablet_lookups_ms =
TransactionRpcTimeout().ToMilliseconds() + 500;
auto txn = CreateTransaction();
auto result = WriteRow(CreateSession(txn), 0 /* key */, 1 /* value */);
ASSERT_TRUE(!result.ok() && result.status().IsTimedOut()) << "Result: " << result;
}
TEST_F(QLTransactionTest, ReadWithTimeInFuture) {
WriteData();
server::SkewedClockDeltaChanger delta_changer(100ms, skewed_clock_);
for (size_t i = 0; i != 100; ++i) {
auto transaction = CreateTransaction2();
auto session = CreateSession(transaction);
VerifyRows(session);
}
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, WriteSameKey) {
ASSERT_NO_FATALS(WriteDataWithRepetition());
std::this_thread::sleep_for(1s); // Wait some time for intents to apply.
ASSERT_NO_FATALS(VerifyData());
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, WriteSameKeyWithIntents) {
DisableApplyingIntents();
ASSERT_NO_FATALS(WriteDataWithRepetition());
ASSERT_NO_FATALS(VerifyData());
ASSERT_OK(cluster_->RestartSync());
}
// Commit flags says whether we should commit write txn during this test.
void QLTransactionTest::TestReadRestart(bool commit) {
SetAtomicFlag(250000ULL, &FLAGS_max_clock_skew_usec);
{
auto write_txn = CreateTransaction();
WriteRows(CreateSession(write_txn));
if (commit) {
ASSERT_OK(write_txn->CommitFuture().get());
}
BOOST_SCOPE_EXIT(write_txn, commit) {
if (!commit) {
write_txn->Abort();
}
} BOOST_SCOPE_EXIT_END;
server::SkewedClockDeltaChanger delta_changer(-100ms, skewed_clock_);
auto txn1 = CreateTransaction2();
BOOST_SCOPE_EXIT(txn1, commit) {
if (!commit) {
txn1->Abort();
}
} BOOST_SCOPE_EXIT_END;
auto session = CreateSession(txn1);
if (commit) {
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, KeyForTransactionAndIndex(0, r));
ASSERT_NOK(row);
ASSERT_EQ(ql::ErrorCode::RESTART_REQUIRED, ql::GetErrorCode(row.status()))
<< "Bad row: " << row;
}
auto txn2 = txn1->CreateRestartedTransaction();
BOOST_SCOPE_EXIT(txn2) {
txn2->Abort();
} BOOST_SCOPE_EXIT_END;
session->SetTransaction(txn2);
VerifyRows(session);
VerifyData();
} else {
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, KeyForTransactionAndIndex(0, r));
ASSERT_TRUE(!row.ok() && row.status().IsNotFound()) << "Bad row: " << row;
}
}
}
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, ReadRestart) {
TestReadRestart();
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, ReadRestartWithIntents) {
DisableApplyingIntents();
TestReadRestart();
}
TEST_F(QLTransactionTest, ReadRestartWithPendingIntents) {
FLAGS_transaction_allow_rerequest_status_in_tests = false;
DisableApplyingIntents();
TestReadRestart(false /* commit */);
}
// Non transactional restart happens in server, so we just checking that we read correct values.
// Skewed clocks are used because there could be case when applied intents or commit transaction
// has time greater than max safetime to read, that causes restart.
TEST_F(QLTransactionTest, ReadRestartNonTransactional) {
const auto kClockSkew = 500ms;
SetAtomicFlag(1000000ULL, &FLAGS_max_clock_skew_usec);
DisableTransactionTimeout();
auto delta_changers = SkewClocks(cluster_.get(), kClockSkew);
constexpr size_t kTotalTransactions = 10;
for (size_t i = 0; i != kTotalTransactions; ++i) {
SCOPED_TRACE(Format("Transaction $0", i));
auto txn = CreateTransaction();
WriteRows(CreateSession(txn), i);
ASSERT_OK(txn->CommitFuture().get());
ASSERT_NO_FATALS(VerifyRows(CreateSession(), i));
// We propagate hybrid time, so when commit and read finishes, all servers has about the same
// physical component. We are waiting double skew, until time on servers became skewed again.
std::this_thread::sleep_for(kClockSkew * 2);
}
cluster_->Shutdown(); // Need to shutdown cluster before resetting clock back.
cluster_.reset();
}
TEST_F(QLTransactionTest, WriteRestart) {
SetAtomicFlag(250000ULL, &FLAGS_max_clock_skew_usec);
const std::string kExtraColumn = "v2";
std::unique_ptr<YBTableAlterer> table_alterer(client_->NewTableAlterer(kTableName));
table_alterer->AddColumn(kExtraColumn)->Type(DataType::INT32);
ASSERT_OK(table_alterer->Alter());
ASSERT_OK(table_.Open(kTableName, client_.get())); // Reopen to update schema version.
WriteData();
server::SkewedClockDeltaChanger delta_changer(-100ms, skewed_clock_);
auto txn1 = CreateTransaction2();
YBTransactionPtr txn2;
auto session = CreateSession(txn1);
for (bool retry : {false, true}) {
for (size_t r = 0; r != kNumRows; ++r) {
const auto op = table_.NewWriteOp(QLWriteRequestPB::QL_STMT_UPDATE);
auto* const req = op->mutable_request();
auto key = KeyForTransactionAndIndex(0, r);
auto old_value = ValueForTransactionAndIndex(0, r, WriteOpType::INSERT);
auto value = ValueForTransactionAndIndex(0, r, WriteOpType::UPDATE);
QLAddInt32HashValue(req, key);
table_.AddInt32ColumnValue(req, kExtraColumn, value);
auto cond = req->mutable_where_expr()->mutable_condition();
table_.SetInt32Condition(cond, kValueColumn, QLOperator::QL_OP_EQUAL, old_value);
req->mutable_column_refs()->add_ids(table_.ColumnId(kValueColumn));
LOG(INFO) << "Updating value";
auto status = session->ApplyAndFlush(op);
ASSERT_OK(status);
if (!retry) {
ASSERT_EQ(QLResponsePB::YQL_STATUS_RESTART_REQUIRED_ERROR, op->response().status());
} else {
ASSERT_EQ(QLResponsePB::YQL_STATUS_OK, op->response().status());
}
}
if (!retry) {
txn2 = txn1->CreateRestartedTransaction();
session->SetTransaction(txn2);
}
}
txn2->CommitFuture().wait();
VerifyData();
VerifyData(1, WriteOpType::UPDATE, kExtraColumn);
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
// Commit flags says whether we should commit write txn during this test.
TEST_F(QLTransactionTest, WriteAfterReadRestart) {
const auto kClockDelta = 100ms;
SetAtomicFlag(250000ULL, &FLAGS_max_clock_skew_usec);
auto write_txn = CreateTransaction();
WriteRows(CreateSession(write_txn));
ASSERT_OK(write_txn->CommitFuture().get());
server::SkewedClockDeltaChanger delta_changer(-kClockDelta, skewed_clock_);
auto txn1 = CreateTransaction2();
auto session = CreateSession(txn1);
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, KeyForTransactionAndIndex(0, r));
ASSERT_NOK(row);
ASSERT_EQ(ql::ErrorCode::RESTART_REQUIRED, ql::GetErrorCode(row.status()))
<< "Bad row: " << row;
}
{
// To reset clock back.
auto temp_delta_changed = std::move(delta_changer);
}
auto txn2 = txn1->CreateRestartedTransaction();
session->SetTransaction(txn2);
VerifyRows(session);
WriteRows(session, 0, WriteOpType::UPDATE);
ASSERT_OK(txn2->CommitFuture().get());
VerifyData(1, WriteOpType::UPDATE);
}
TEST_F(QLTransactionTest, Child) {
auto txn = CreateTransaction();
TransactionManager manager2(client_, clock_, client::LocalTabletFilter());
auto data_pb = txn->PrepareChildFuture().get();
ASSERT_OK(data_pb);
auto data = ChildTransactionData::FromPB(*data_pb);
ASSERT_OK(data);
auto txn2 = std::make_shared<YBTransaction>(&manager2, std::move(*data));
WriteRows(CreateSession(txn2), 0);
auto result = txn2->FinishChild();
ASSERT_OK(result);
ASSERT_OK(txn->ApplyChildResult(*result));
ASSERT_OK(txn->CommitFuture().get());
ASSERT_NO_FATALS(VerifyData());
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, ChildReadRestart) {
SetAtomicFlag(250000ULL, &FLAGS_max_clock_skew_usec);
{
auto write_txn = CreateTransaction();
WriteRows(CreateSession(write_txn));
ASSERT_OK(write_txn->CommitFuture().get());
}
server::SkewedClockDeltaChanger delta_changer(-100ms, skewed_clock_);
auto parent_txn = CreateTransaction2();
auto data_pb = parent_txn->PrepareChildFuture().get();
ASSERT_OK(data_pb);
auto data = ChildTransactionData::FromPB(*data_pb);
ASSERT_OK(data);
server::ClockPtr clock3(new server::HybridClock(skewed_clock_));
ASSERT_OK(clock3->Init());
TransactionManager manager3(client_, clock3, client::LocalTabletFilter());
auto child_txn = std::make_shared<YBTransaction>(&manager3, std::move(*data));
auto session = CreateSession(child_txn);
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, KeyForTransactionAndIndex(0, r));
ASSERT_NOK(row);
ASSERT_EQ(ql::ErrorCode::RESTART_REQUIRED, ql::GetErrorCode(row.status()))
<< "Bad row: " << row;
}
auto result = child_txn->FinishChild();
ASSERT_OK(result);
ASSERT_OK(parent_txn->ApplyChildResult(*result));
auto master2_txn = parent_txn->CreateRestartedTransaction();
session->SetTransaction(master2_txn);
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, KeyForTransactionAndIndex(0, r));
ASSERT_OK(row);
ASSERT_EQ(ValueForTransactionAndIndex(0, r, WriteOpType::INSERT), *row);
}
ASSERT_NO_FATALS(VerifyData());
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, InsertUpdate) {
DisableApplyingIntents();
WriteData(); // Add data
WriteData(); // Update data
VerifyData();
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, Cleanup) {
WriteData();
VerifyData();
// Wait transaction apply. Otherwise count could be non zero.
ASSERT_OK(WaitTransactionsCleaned());
VerifyData();
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, Heartbeat) {
auto txn = CreateTransaction();
auto session = CreateSession(txn);
WriteRows(session);
std::this_thread::sleep_for(GetTransactionTimeout() * 2);
CountDownLatch latch(1);
txn->Commit([&latch](const Status& status) {
EXPECT_OK(status);
latch.CountDown();
});
latch.Wait();
VerifyData();
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, Expire) {
SetDisableHeartbeatInTests(true);
auto txn = CreateTransaction();
auto session = CreateSession(txn);
WriteRows(session);
std::this_thread::sleep_for(GetTransactionTimeout() * 2);
CountDownLatch latch(1);
txn->Commit([&latch](const Status& status) {
EXPECT_TRUE(status.IsExpired()) << "Bad status: " << status.ToString();
latch.CountDown();
});
latch.Wait();
std::this_thread::sleep_for(std::chrono::microseconds(FLAGS_transaction_heartbeat_usec * 2));
ASSERT_OK(cluster_->CleanTabletLogs());
ASSERT_EQ(0, CountTransactions());
}
TEST_F(QLTransactionTest, PreserveLogs) {
SetDisableHeartbeatInTests(true);
DisableTransactionTimeout();
std::vector<std::shared_ptr<YBTransaction>> transactions;
constexpr size_t kTransactions = 20;
for (size_t i = 0; i != kTransactions; ++i) {
auto txn = CreateTransaction();
auto session = CreateSession(txn);
WriteRows(session, i);
transactions.push_back(std::move(txn));
std::this_thread::sleep_for(100ms);
}
LOG(INFO) << "Request clean";
ASSERT_OK(cluster_->CleanTabletLogs());
ASSERT_OK(cluster_->RestartSync());
CountDownLatch latch(kTransactions);
for (auto& transaction : transactions) {
transaction->Commit([&latch](const Status& status) {
EXPECT_OK(status);
latch.CountDown();
});
}
latch.Wait();
VerifyData(kTransactions);
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, ResendApplying) {
DisableApplyingIntents();
WriteData();
std::this_thread::sleep_for(5s); // Transaction should not be applied here.
ASSERT_NE(0, CountTransactions());
SetIgnoreApplyingProbability(0.0);
ASSERT_OK(WaitTransactionsCleaned());
VerifyData();
ASSERT_OK(cluster_->RestartSync());
CheckNoRunningTransactions();
}
TEST_F(QLTransactionTest, ConflictResolution) {
constexpr size_t kTotalTransactions = 5;
constexpr size_t kNumRows = 10;
std::vector<YBTransactionPtr> transactions;
std::vector<YBSessionPtr> sessions;
std::vector<std::vector<YBqlWriteOpPtr>> write_ops(kTotalTransactions);
CountDownLatch latch(kTotalTransactions);
for (size_t i = 0; i != kTotalTransactions; ++i) {
transactions.push_back(CreateTransaction());
auto session = CreateSession(transactions.back());
sessions.push_back(session);
for (size_t r = 0; r != kNumRows; ++r) {
write_ops[i].push_back(ASSERT_RESULT(WriteRow(
sessions.back(), r, i, WriteOpType::INSERT, Flush::kFalse)));
}
session->FlushAsync([&latch](const Status& status) { latch.CountDown(); });
}
latch.Wait();
latch.Reset(transactions.size());
std::atomic<size_t> successes(0);
std::atomic<size_t> failures(0);
for (size_t i = 0; i != kTotalTransactions; ++i) {
bool success = true;
for (auto& op : write_ops[i]) {
if (!op->succeeded()) {
success = false;
break;
}
}
if (!success) {
failures.fetch_add(1, std::memory_order_release);
latch.CountDown(1);
continue;
}
transactions[i]->Commit([&latch, &successes, &failures](const Status& status) {
if (status.ok()) {
successes.fetch_add(1, std::memory_order_release);
} else {
failures.fetch_add(1, std::memory_order_release);
}
latch.CountDown(1);
});
}
latch.Wait();
LOG(INFO) << "Committed, successes: " << successes.load() << ", failures: " << failures.load();
ASSERT_GE(successes.load(std::memory_order_acquire), 1);
ASSERT_GE(failures.load(std::memory_order_acquire), 1);
auto session = CreateSession();
std::vector<int32_t> values;
for (size_t r = 0; r != kNumRows; ++r) {
auto row = SelectRow(session, r);
ASSERT_OK(row);
values.push_back(*row);
}
for (const auto& value : values) {
ASSERT_EQ(values.front(), value) << "Values: " << yb::ToString(values);
}
}
TEST_F(QLTransactionTest, SimpleWriteConflict) {
auto transaction = CreateTransaction();
WriteRows(CreateSession(transaction));
WriteRows(CreateSession());
ASSERT_NOK(transaction->CommitFuture().get());
}
void QLTransactionTest::TestWriteConflicts(bool do_restarts) {
struct ActiveTransaction {
YBTransactionPtr transaction;
YBSessionPtr session;
std::future<Status> flush_future;
std::future<Status> commit_future;
};
constexpr size_t kActiveTransactions = 50;
constexpr auto kTestTime = 60s;
constexpr int kTotalKeys = 5;
std::vector<ActiveTransaction> active_transactions;
auto stop = std::chrono::steady_clock::now() + kTestTime;
std::thread restart_thread;
if (do_restarts) {
restart_thread = std::thread([this, stop] {
int it = 0;
while (std::chrono::steady_clock::now() < stop) {
std::this_thread::sleep_for(5s);
ASSERT_OK(cluster_->mini_tablet_server(++it % cluster_->num_tablet_servers())->Restart());
}
});
}
int value = 0;
size_t tries = 0;
size_t committed = 0;
size_t flushed = 0;
for (;;) {
auto expired = std::chrono::steady_clock::now() >= stop;
if (expired) {
if (active_transactions.empty()) {
break;
}
LOG(INFO) << "Time expired, remaining transactions: " << active_transactions.size();
for (const auto& txn : active_transactions) {
LOG(INFO) << "TXN: " << txn.transaction->ToString() << ", "
<< (!txn.commit_future.valid() ? "Flushing" : "Committing");
}
}
while (!expired && active_transactions.size() < kActiveTransactions) {
auto key = RandomUniformInt(1, kTotalKeys);
ActiveTransaction active_txn;
active_txn.transaction = CreateTransaction();
active_txn.session = CreateSession(active_txn.transaction);
const auto op = table_.NewInsertOp();
auto* const req = op->mutable_request();
QLAddInt32HashValue(req, key);
table_.AddInt32ColumnValue(req, kValueColumn, ++value);
ASSERT_OK(active_txn.session->Apply(op));
active_txn.flush_future = active_txn.session->FlushFuture();
++tries;
active_transactions.push_back(std::move(active_txn));
}
auto w = active_transactions.begin();
for (auto i = active_transactions.begin(); i != active_transactions.end(); ++i) {
if (!i->commit_future.valid()) {
if (i->flush_future.wait_for(0s) == std::future_status::ready) {
auto flush_status = i->flush_future.get();
if (!flush_status.ok()) {
LOG(INFO) << "Flush failed: " << flush_status;
continue;
}
++flushed;
i->commit_future = i->transaction->CommitFuture();
}
} else if (i->commit_future.wait_for(0s) == std::future_status::ready) {
auto commit_status = i->commit_future.get();
if (!commit_status.ok()) {
LOG(INFO) << "Commit failed: " << commit_status;
continue;
}
++committed;
continue;
}
if (w != i) {
*w = std::move(*i);
}
++w;
}
active_transactions.erase(w, active_transactions.end());
std::this_thread::sleep_for(expired ? 1s : 100ms);
}
if (do_restarts) {
restart_thread.join();
}
LOG(INFO) << "Committed: " << committed << ", flushed: " << flushed << ", tries: " << tries;
ASSERT_GE(committed, kTotalKeys);
ASSERT_GT(flushed, committed);
ASSERT_GT(flushed, kActiveTransactions);
ASSERT_GT(tries, flushed);
}
class WriteConflictsTest : public QLTransactionTest {
protected:
uint64_t log_segment_size_bytes() const override {
return 0;
}
};
TEST_F_EX(QLTransactionTest, WriteConflicts, WriteConflictsTest) {
TestWriteConflicts(false /* do_restarts */);
}
TEST_F_EX(QLTransactionTest, WriteConflictsWithRestarts, WriteConflictsTest) {
TestWriteConflicts(true /* do_restarts */);
}
TEST_F(QLTransactionTest, ResolveIntentsWriteReadUpdateRead) {
DisableApplyingIntents();
WriteData();
VerifyData();
WriteData(WriteOpType::UPDATE);
VerifyData(1, WriteOpType::UPDATE);
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, ResolveIntentsWriteReadWithinTransactionAndRollback) {
SetAtomicFlag(0ULL, &FLAGS_max_clock_skew_usec); // To avoid read restart in this test.
DisableApplyingIntents();
// Write { 1 -> 1, 2 -> 2 }.
{
auto session = CreateSession();
ASSERT_OK(WriteRow(session, 1, 1));
ASSERT_OK(WriteRow(session, 2, 2));
}
{
// Start T1.
auto txn = CreateTransaction();
auto session = CreateSession(txn);
// T1: Update { 1 -> 11, 2 -> 12 }.
ASSERT_OK(UpdateRow(session, 1, 11));
ASSERT_OK(UpdateRow(session, 2, 12));
// T1: Should read { 1 -> 11, 2 -> 12 }.
VERIFY_ROW(session, 1, 11);
VERIFY_ROW(session, 2, 12);
txn->Abort();
}
ASSERT_OK(WaitTransactionsCleaned());
// Should read { 1 -> 1, 2 -> 2 }, since T1 has been aborted.
{
auto session = CreateSession();
VERIFY_ROW(session, 1, 1);
VERIFY_ROW(session, 2, 2);
}
ASSERT_EQ(CountIntents(), 0);
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, CheckCompactionAbortCleanup) {
SetAtomicFlag(0ULL, &FLAGS_max_clock_skew_usec); // To avoid read restart in this test.
FLAGS_transaction_disable_proactive_cleanup_in_tests = true;
FLAGS_aborted_intent_cleanup_ms = 1000; // 1 sec
// Write { 1 -> 1, 2 -> 2 }.
{
auto session = CreateSession();
ASSERT_OK(WriteRow(session, 1, 1));
ASSERT_OK(WriteRow(session, 2, 2));
}
{
// Start T1.
auto txn = CreateTransaction();
auto session = CreateSession(txn);
// T1: Update { 1 -> 11, 2 -> 12 }.
ASSERT_OK(UpdateRow(session, 1, 11));
ASSERT_OK(UpdateRow(session, 2, 12));
// T1: Should read { 1 -> 11, 2 -> 12 }.
VERIFY_ROW(session, 1, 11);
VERIFY_ROW(session, 2, 12);
txn->Abort();
}
ASSERT_OK(WaitTransactionsCleaned());
std::this_thread::sleep_for(std::chrono::microseconds(FLAGS_aborted_intent_cleanup_ms));
tserver::TSTabletManager::TabletPeers peers;
cluster_->mini_tablet_server(0)->server()->tablet_manager()->GetTabletPeers(&peers);
for (std::shared_ptr<tablet::TabletPeer> peer : peers) {
peer->tablet()->ForceRocksDBCompactInTest();
}
// Should read { 1 -> 1, 2 -> 2 }, since T1 has been aborted.
{
auto session = CreateSession();
VERIFY_ROW(session, 1, 1);
VERIFY_ROW(session, 2, 2);
}
ASSERT_EQ(CountIntents(), 0);
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, ResolveIntentsWriteReadBeforeAndAfterCommit) {
SetAtomicFlag(0ULL, &FLAGS_max_clock_skew_usec); // To avoid read restart in this test.
DisableApplyingIntents();
// Write { 1 -> 1, 2 -> 2 }.
{
auto session = CreateSession();
ASSERT_OK(WriteRow(session, 1, 1));
ASSERT_OK(WriteRow(session, 2, 2));
}
// Start T1.
auto txn1 = CreateTransaction();
auto session1 = CreateSession(txn1);
// T1: Update { 1 -> 11, 2 -> 12 }.
ASSERT_OK(UpdateRow(session1, 1, 11));
ASSERT_OK(UpdateRow(session1, 2, 12));
// Start T2.
auto txn2 = CreateTransaction();
auto session2 = CreateSession(txn2);
// T2: Should read { 1 -> 1, 2 -> 2 }.
VERIFY_ROW(session2, 1, 1);
VERIFY_ROW(session2, 2, 2);
// T1: Commit
CommitAndResetSync(&txn1);
// T2: Should still read { 1 -> 1, 2 -> 2 }, because it should read at the time of it's start.
VERIFY_ROW(session2, 1, 1);
VERIFY_ROW(session2, 2, 2);
// Simple read should get { 1 -> 11, 2 -> 12 }, since T1 has been already committed.
{
auto session = CreateSession();
VERIFY_ROW(session, 1, 11);
VERIFY_ROW(session, 2, 12);
}
CommitAndResetSync(&txn2);
ASSERT_OK(cluster_->RestartSync());
}
TEST_F(QLTransactionTest, ResolveIntentsCheckConsistency) {
SetAtomicFlag(0ULL, &FLAGS_max_clock_skew_usec); // To avoid read restart in this test.
DisableApplyingIntents();
// Write { 1 -> 1, 2 -> 2 }.
{
auto session = CreateSession();
ASSERT_OK(WriteRow(session, 1, 1));
ASSERT_OK(WriteRow(session, 2, 2));
}
// Start T1.
auto txn1 = CreateTransaction();
// T1: Update { 1 -> 11, 2 -> 12 }.
{
auto session = CreateSession(txn1);
ASSERT_OK(UpdateRow(session, 1, 11));
ASSERT_OK(UpdateRow(session, 2, 12));
}
// T1: Request commit.
CountDownLatch commit_latch(1);
txn1->Commit([&commit_latch](const Status& status) {
ASSERT_OK(status);
commit_latch.CountDown(1);
});
// Start T2.
auto txn2 = CreateTransaction();
// T2: Should read { 1 -> 1, 2 -> 2 } even in case T1 is committed between reading k1 and k2.
{
auto session = CreateSession(txn2);
VERIFY_ROW(session, 1, 1);
commit_latch.Wait();
VERIFY_ROW(session, 2, 2);
}
// Simple read should get { 1 -> 11, 2 -> 12 }, since T1 has been already committed.
{
auto session = CreateSession();
VERIFY_ROW(session, 1, 11);
VERIFY_ROW(session, 2, 12);
}
CommitAndResetSync(&txn2);
ASSERT_OK(cluster_->RestartSync());
}
// This test launches write thread, that writes increasing value to key using transaction.
// Then it launches multiple read threads, each of them tries to read this key and
// verifies that its value is at least the same like it was written before read was started.
//
// It is don't for multiple keys sequentially. So those keys are located on different tablets
// and tablet servers, and we test different cases of clock skew.
TEST_F(QLTransactionTest, CorrectStatusRequestBatching) {
const auto kClockSkew = 100ms;
constexpr auto kMinWrites = RegularBuildVsSanitizers(25, 1);
constexpr auto kMinReads = 10;
constexpr size_t kConcurrentReads = RegularBuildVsSanitizers<size_t>(20, 5);
FLAGS_transaction_delay_status_reply_usec_in_tests = 200000;
FLAGS_log_segment_size_bytes = 0;
SetAtomicFlag(std::chrono::microseconds(kClockSkew).count() * 3, &FLAGS_max_clock_skew_usec);
auto delta_changers = SkewClocks(cluster_.get(), kClockSkew);
for (int32_t key = 0; key != 10; ++key) {
std::atomic<bool> stop(false);
std::atomic<int32_t> value(0);
std::thread write_thread([this, key, &stop, &value] {
auto session = CreateSession();
while (!stop) {
auto txn = CreateTransaction();
session->SetTransaction(txn);
auto write_result = WriteRow(session, key, value + 1);
if (write_result.ok()) {
auto status = txn->CommitFuture().get();
if (status.ok()) {
++value;
}
}
}
});
std::vector<std::thread> read_threads;
std::array<std::atomic<size_t>, kConcurrentReads> reads;
for (auto& read : reads) {
read.store(0);
}
for (size_t i = 0; i != kConcurrentReads; ++i) {
read_threads.emplace_back([this, key, &stop, &value, &read = reads[i]] {
auto session = CreateSession();
bool ok = false;
BOOST_SCOPE_EXIT(&ok, &stop) {
if (!ok) {
stop = true;
}
} BOOST_SCOPE_EXIT_END;
while (!stop) {
auto value_before_start = value.load();
YBqlReadOpPtr op = ReadRow(session, key);
ASSERT_OK(session->Flush());
ASSERT_EQ(op->response().status(), QLResponsePB::YQL_STATUS_OK)
<< op->response().ShortDebugString();
auto rowblock = yb::ql::RowsResult(op.get()).GetRowBlock();
int32_t current_value;
if (rowblock->row_count() == 0) {
current_value = 0;
} else {
current_value = rowblock->row(0).column(0).int32_value();
}
ASSERT_GE(current_value, value_before_start);
++read;
}
ok = true;
});
}
auto deadline = std::chrono::steady_clock::now() + 10s;
while (!stop && std::chrono::steady_clock::now() < deadline) {
std::this_thread::sleep_for(100ms);
}
// Already failed
bool failed = stop.exchange(true);
write_thread.join();
for (auto& thread : read_threads) {
thread.join();
}
if (failed) {
break;
}
LOG(INFO) << "Writes: " << value.load() << ", reads: " << yb::ToString(reads);
EXPECT_GE(value.load(), kMinWrites);
for (auto& read : reads) {
EXPECT_GE(read.load(), kMinReads);
}
}
cluster_->Shutdown(); // Need to shutdown cluster before resetting clock back.
cluster_.reset();
}
struct TransactionState {
YBTransactionPtr transaction;
std::shared_future<TransactionMetadata> metadata_future;
std::future<Status> commit_future;
std::future<Result<tserver::GetTransactionStatusResponsePB>> status_future;
TransactionMetadata metadata;
HybridTime status_time = HybridTime::kMin;
TransactionStatus last_status = TransactionStatus::PENDING;
void CheckStatus() {
ASSERT_TRUE(status_future.valid());
ASSERT_EQ(status_future.wait_for(NonTsanVsTsan(3s, 10s)), std::future_status::ready);
auto resp = status_future.get();
ASSERT_OK(resp);
if (resp->status() == TransactionStatus::ABORTED) {
ASSERT_TRUE(commit_future.valid());
transaction = nullptr;
return;
}
auto new_time = HybridTime(resp->status_hybrid_time());
if (last_status == TransactionStatus::PENDING) {
if (resp->status() == TransactionStatus::PENDING) {
ASSERT_GE(new_time, status_time);
} else {
ASSERT_EQ(TransactionStatus::COMMITTED, resp->status());
ASSERT_GT(new_time, status_time);
}
} else {
ASSERT_EQ(last_status, TransactionStatus::COMMITTED);
ASSERT_EQ(resp->status(), TransactionStatus::COMMITTED)
<< "Bad transaction status: " << TransactionStatus_Name(resp->status());
ASSERT_EQ(status_time, new_time);
}
status_time = new_time;
last_status = resp->status();
}
};
// Test transaction status evolution.
// The following should happen:
// If both previous and new transaction state are PENDING, then the new time of status is >= the
// old time of status.
// Previous - PENDING, new - COMMITTED, new_time > old_time.
// Previous - COMMITTED, new - COMMITTED, new_time == old_time.
// All other cases are invalid.
TEST_F(QLTransactionTest, StatusEvolution) {
// We don't care about exact probability of create/commit operations.
// Just create rate should be higher than commit one.
const int kTransactionCreateChance = 10;