Skip to content

Commit

Permalink
#2461 Re-enable running only the relevant subset of C++ tests on macOS
Browse files Browse the repository at this point in the history
Summary:
Problem caused by `ninja` version mismatch on some macminis.
Locally installed version is `1.8.2` and  homebrew installed version is `1.9.0`.
To solve the issue locally installed `ninja` was removed from all macminis.
Now it is safe to enable affected test detection mechanism.

Test Plan: Jenkins: build platform: mac

Reviewers: mikhail

Reviewed By: mikhail

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7357
  • Loading branch information
d-uspenskiy committed Oct 17, 2019
1 parent ce69707 commit 1afc803
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions build-support/jenkins/build-and-test.sh
Expand Up @@ -224,9 +224,7 @@ log "Finished running a light-weight lint script on the Java code"
YB_BUILD_JAVA=${YB_BUILD_JAVA:-1}
YB_BUILD_CPP=${YB_BUILD_CPP:-1}

# Temporarily disable running affected tests only on macOS because of
# https://github.com/YugaByte/yugabyte-db/issues/1096
if [[ -z ${YB_RUN_AFFECTED_TESTS_ONLY:-} ]] && is_jenkins_phabricator_build && ! is_mac; then
if [[ -z ${YB_RUN_AFFECTED_TESTS_ONLY:-} ]] && is_jenkins_phabricator_build; then
log "YB_RUN_AFFECTED_TESTS_ONLY is not set, and this is a Jenkins Phabricator test." \
"Setting YB_RUN_AFFECTED_TESTS_ONLY=1 automatically."
export YB_RUN_AFFECTED_TESTS_ONLY=1
Expand Down

0 comments on commit 1afc803

Please sign in to comment.