Skip to content

Commit

Permalink
This commit provides additional functionality that is logically relat…
Browse files Browse the repository at this point in the history
…ed to the

earlier commit 7e4108a

Original commit message:

#467: Fix several issues with remote bootstrap

Summary:
The following issues were fixed:
1) nsessions was not passed to ctor of RemoteBootstrapSession, so rate limiter was disabled in service side.
2) When rate limiter is inactive in remote bootstrap service, it ignores max chunk size that was sent by client.
3) Since we allocate read buffer by chunks and don't move, to pass data of size N we should set buffer limit to N+chunk size.

Test Plan: ybd --cxx-test ql-transaction-test --gtest_filter QLTransactionTest.RemoteBootstrap

Reviewers: mikhail, kannan, hector

Reviewed By: hector

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D5450
  • Loading branch information
spolitov authored and mbautin committed Jul 11, 2019
1 parent c3f06f6 commit 9c8e1d6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ent/src/yb/tserver/remote_bootstrap_session.h
Expand Up @@ -16,7 +16,7 @@ class RemoteBootstrapSession : public yb::tserver::RemoteBootstrapSession {
std::string session_id,
std::string requestor_uuid,
FsManager* fs_manager,
const std::atomic<int>* nsessions = nullptr)
const std::atomic<int>* nsessions)
: super(tablet_peer, session_id, requestor_uuid, fs_manager, nsessions) {}

CHECKED_STATUS InitSnapshotFiles() override;
Expand Down

0 comments on commit 9c8e1d6

Please sign in to comment.