[#10163] dst - Disable large transaction batch apply until it does no…

…t affect tablet splitting

Summary:
We currently have a bug whereby ApplyTransactionState records can throw off our split key
calculation. This revision effectively turns off large transaction batching entirely. We should
re-enable it once this bug is fixed.

Test Plan: Jenkins

Reviewers: bogdan, timur, rthallam

Reviewed By: rthallam

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D13906

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgRegressLargeTable.java

@@ -49,6 +49,9 @@ public int getTestMethodTimeoutSec() {
   protected Map<String, String> getTServerFlags() {
     Map<String, String> flags = super.getTServerFlags();
     flags.put("ysql_pg_conf", TURN_OFF_COPY_FROM_BATCH_TRANSACTION);
+    // TODO(#10163) -- Remove this to ensure the test is against the default value #10163 is
+    // resolved.
+    flags.put("txn_max_apply_batch_records", "100000");
     return flags;
   }
 

src/yb/docdb/docdb.cc

@@ -12,6 +12,7 @@
 //
 
 #include <algorithm>
+#include <limits>
 #include <memory>
 #include <stack>
 #include <string>
@@ -76,7 +77,8 @@ DEFINE_bool(enable_transaction_sealing, false,
             "Whether transaction sealing is enabled.");
 DEFINE_test_flag(bool, fail_on_replicated_batch_idx_set_in_txn_record, false,
                  "Fail when a set of replicated batch indexes is found in txn record.");
-DEFINE_int32(txn_max_apply_batch_records, 100000,
+// TODO(#10163) -- Revert this flag to it's previous value once #10163 is resolved.
+DEFINE_int32(txn_max_apply_batch_records, std::numeric_limits<int32>::max(),
              "Max number of apply records allowed in single RocksDB batch. "
              "When a transaction's data in one tablet does not fit into specified number of "
              "records, it will be applied using multiple RocksDB write batches.");