Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add dockerfile to main repo #104

Open
everyonce opened this issue Mar 19, 2018 · 6 comments
Open

Please add dockerfile to main repo #104

everyonce opened this issue Mar 19, 2018 · 6 comments
Assignees
Labels
kind/enhancement This is an enhancement of an existing feature

Comments

@everyonce
Copy link

I'd like to be able to make codebase changes and duplicate what I'm getting from dockerhub with my changes.

@everyonce
Copy link
Author

Also, I got the code for the current Dockerfile in my other issue I opened, but it gets binaries from a packages file that is not created by the build process. Can I get a little bit of help on the in-between steps for that?

@rkarthik007
Copy link
Collaborator

Sure thing @everyonce, forgot to add there sorry.

Two ways you could do this:

  1. These are just the standard binaries available for download. So for example, if you're building linux container, you could just download from: https://docs.yugabyte.com/quick-start/install/#linux
  2. Alternatively, you can build the latest package. Instructions on the github page (we will move this to our docs soon): https://github.com/YugaByte/yugabyte-db#building-yugabyte-code

You should have a tar.gz at the end of either of these steps which is what is being copied in this step:

COPY packages/yugabyte*.tar.gz /tmp
RUN tar -xvf /tmp/yugabyte*.tar.gz --strip 1

After this step, /home/yugabyte is assumed to contain the contents of the tar package (without the holding directory). In other words, you should see a bin directory so that next step works:

RUN bin/configure

Pasting the docker file here again for reference:

FROM centos:7
MAINTAINER YugaByte
ENV container=yugabyte-db

ENV YB_HOME=/home/yugabyte
WORKDIR $YB_HOME

COPY packages/yugabyte*.tar.gz /tmp
RUN tar -xvf /tmp/yugabyte*.tar.gz --strip 1
RUN bin/configure

# Expose the required ports.
EXPOSE 7000 7100 9000 9100 12000 11000 6379 9042 10100

# Create the data directories.
VOLUME ["/mnt/disk0", "/mnt/disk1"]

@rkarthik007
Copy link
Collaborator

Ah just saw your comment that you wanted to replicate your changes to the code base, so you probably want to go with option 2 (building the codebase). cc @mbautin

@everyonce
Copy link
Author

Thanks for the answer. I've run the build successfully (and put in a PR for missing packages needed), and it doesn't produce any tar files. It does create files like the configure file in the /bin directory, but no tar files, so I'm not sure how to build those like the Dockerfile is expecting.
Thanks!

@bmatican
Copy link
Contributor

Hey @everyonce , you can try running ./yb_release --edition ce. Assuming that works, it will generate a .tar.gz in the expected format and print out the path to it.

I've also filed #107 to simplify the args, so you wouldn't need the --edition ce part.

@everyonce
Copy link
Author

This works, thanks!!

@rkarthik007 rkarthik007 added the kind/enhancement This is an enhancement of an existing feature label Apr 6, 2018
tvesely pushed a commit to tvesely/yugabyte-db that referenced this issue Feb 28, 2024
…" by "C"

This replacement does not impact the coverage of the regression tests as
there is no data dependent on that in the test suite, and using C gives
much more flexibility to the environments where this runs.  This will
make easier the integration of automated tests into the tree.

Extracted from pull request yugabyte#104.

Author: Seino Yuki
Backpatch-through: 10
tvesely pushed a commit to tvesely/yugabyte-db that referenced this issue Feb 28, 2024
CI tests run on a branch where a commit is pushed or a pull-request is
created, with the corresponding PostgreSQL version. Also, there is a
scheduled test on every Sunday.

Per pull request yugabyte#104, and test script written by Masahiko Sawada.

Author: Masahiko Sawada, Seino Yuki
Backpath-through: 10
jasonyb pushed a commit that referenced this issue Mar 13, 2024
Run the testsuite on travis-ci.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This is an enhancement of an existing feature
Projects
Development

No branches or pull requests

4 participants