Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Rename universe replication does not work with multiple renames #10845

Closed
hulien22 opened this issue Dec 10, 2021 · 0 comments
Closed

[xCluster] Rename universe replication does not work with multiple renames #10845

hulien22 opened this issue Dec 10, 2021 · 0 comments
Assignees
@hulien22
Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
xCluster replication

Comments

@hulien22
Copy link
Contributor

hulien22 commented Dec 10, 2021 •
edited
Loading

Issue is that we are not updating the id of the UniverseReplicationInfo, so universe->id() still returns the original id, leading to this bug.

Need to create a new UniverseReplicationInfo with the correct id to replace the previous one.
@hulien22 hulien22 added kind/bug This issue is a bug area/docdb YugabyteDB core features area/cdc Change Data Capture labels Dec 10, 2021
@hulien22 hulien22 self-assigned this Dec 10, 2021
@hulien22 hulien22 added this to To do in xCluster replication via automation Dec 10, 2021
hulien22 added a commit that referenced this issue Dec 13, 2021
@hulien22
[#10845] xCluster: Fix rename universe replication with multiple renames
6ea1257 
Summary:
Making new UniverseReplicationInfo object to replace the previous one, as universe->id() is const
and cannot be modified. Making sure that all these updates are done atomically.

Test Plan:
```
ybd --cxx-test yb-admin-test_ent --gtest_filter XClusterAdminCliTest.TestRenameUniverseReplication
```

Reviewers: rahuldesirazu, nicolas

Reviewed By: nicolas

Subscribers: jvigil, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D14322
hulien22 added a commit that referenced this issue Dec 21, 2021
@hulien22
[BACKPORT 2.6] [#10845] xCluster: Fix rename universe replication wit…
6931210 
…h multiple renames

Summary:
Making new UniverseReplicationInfo object to replace the previous one, as universe->id() is const
and cannot be modified. Making sure that all these updates are done atomically.

Original commit / diff: 6ea1257 / D14322

Test Plan:
```
ybd --cxx-test yb-admin-test_ent --gtest_filter XClusterAdminCliTest.TestRenameUniverseReplication
```

Reviewers: rahuldesirazu, nicolas

Reviewed By: nicolas

Subscribers: bogdan, ybase, jvigil

Differential Revision: https://phabricator.dev.yugabyte.com/D14408
hulien22 added a commit that referenced this issue Dec 21, 2021
@hulien22
[BACKPORT 2.8] [#10845] xCluster: Fix rename universe replication wit…
8ea833f 
…h multiple renames

Summary:
Making new UniverseReplicationInfo object to replace the previous one, as universe->id() is const
and cannot be modified. Making sure that all these updates are done atomically.

Original commit / diff: 6ea1257 / D14322

Test Plan:
```
ybd --cxx-test yb-admin-test_ent --gtest_filter XClusterAdminCliTest.TestRenameUniverseReplication
```

Reviewers: rahuldesirazu, nicolas

Reviewed By: nicolas

Subscribers: bogdan, ybase, jvigil

Differential Revision: https://phabricator.dev.yugabyte.com/D14407
@hulien22 hulien22 closed this as completed May 5, 2022
xCluster replication automation moved this from To do to Done May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulien22 hulien22

Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
xCluster replication
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hulien22