Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Import Preserve firing-on state when cloning row triggers to partitions #11800

Open
tedyu opened this issue Mar 18, 2022 · 0 comments
Open

[YSQL] Import Preserve firing-on state when cloning row triggers to partitions #11800

tedyu opened this issue Mar 18, 2022 · 0 comments
Assignees
@tedyu
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@tedyu
Copy link
Contributor

tedyu commented Mar 18, 2022 •
edited by yugabyte-ci

Jira Link: DB-1225

Description

Upstream commit was fed35bd4a65032f714af6bc88c102d0e90422dee

Commit message was:

When triggers are cloned from partitioned tables to their partitions,
the 'tgenabled' flag (origin/replica/always/disable) was not propagated.
Make it so that the flag on the trigger on partition is initially set to
the same value as on the partitioned table.

Add a test case to verify the behavior.

Backpatch to 11, where this appeared in commit 86f575948c77.

Author: Álvaro Herrera alvherre@alvh.no-ip.org
Reported-by: Justin Pryzby pryzby@telsasoft.com
Discussion: https://postgr.es/m/20200930223450.GA14848@telsasoft.com
@tedyu tedyu added the area/ysql Yugabyte SQL (YSQL) label Mar 18, 2022
@tedyu tedyu self-assigned this Mar 18, 2022
tedyu added a commit that referenced this issue May 25, 2022
@tedyu
[#11800] ysql: Import Preserve firing-on state when cloning row trigg…
eafb356 
…ers to partitions

Summary:
Upstream commit was fed35bd4a65032f714af6bc88c102d0e90422dee

Commit message was:

    When triggers are cloned from partitioned tables to their partitions,
    the 'tgenabled' flag (origin/replica/always/disable) was not propagated.
    Make it so that the flag on the trigger on partition is initially set to
    the same value as on the partitioned table.

    Add a test case to verify the behavior.

    Backpatch to 11, where this appeared in commit 86f575948c77.

    Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
    Reported-by: Justin Pryzby <pryzby@telsasoft.com>
    Discussion: https://postgr.es/m/20200930223450.GA14848@telsasoft.com

Test Plan: Test is added to yb_pg_triggers

Reviewers: amartsinchyk, myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D16066
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
tedyu added a commit that referenced this issue Jun 9, 2022
@tedyu
[Backport to 2.12] [#11800] ysql: Import Preserve firing-on state whe…
37e8f08 
…n cloning row triggers to partitions

Summary:
Original commit was eafb356 / D16066

Upstream commit was fed35bd4a65032f714af6bc88c102d0e90422dee

Commit message was:

When triggers are cloned from partitioned tables to their partitions,
the 'tgenabled' flag (origin/replica/always/disable) was not propagated.
Make it so that the flag on the trigger on partition is initially set to
the same value as on the partitioned table.

Add a test case to verify the behavior.

Backpatch to 11, where this appeared in commit 86f575948c77.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://postgr.es/m/20200930223450.GA14848@telsasoft.com

Test Plan: Jenkins: rebase: 2.12

Reviewers: amartsinchyk, myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D17208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tedyu tedyu

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedyu @yugabyte-ci