Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] gcc9 compile failing on alma8 and ubuntu20.04 #12150

Closed
es1024 opened this issue Apr 13, 2022 · 0 comments
Closed

[DocDB] gcc9 compile failing on alma8 and ubuntu20.04 #12150

es1024 opened this issue Apr 13, 2022 · 0 comments
Assignees
@es1024
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@es1024
Copy link
Contributor

es1024 commented Apr 13, 2022 •
edited by jira bot

Jira Link: DB-8246

Description

Building with gcc9 on alma8 (fastdebug) and ubuntu20.04 (debug) currently fails with the following error:

/-------------------------------------------------------------------------------
| COMPILATION FAILED
|-------------------------------------------------------------------------------
ent/src/yb/tools/yb-admin-test_ent.cc: In member function ‘virtual void yb::tools::XClusterAdminCliTest_Large_TestBootstrapProducerPerformance_Test::TestBody()’:
ent/src/yb/tools/yb-admin-test_ent.cc:1374:21: error: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<yb::client::TableHandle>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
 1374 |   for (int i = 1; i < tables.size(); ++i) {
      |                   ~~^~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Input files:
  src/yb/tools/CMakeFiles/yb-admin-test_ent.dir/__/__/__/ent/src/yb/tools/yb-admin-test_ent.cc.o
  ent/src/yb/tools/yb-admin-test_ent.cc
Output file (from -o): src/yb/tools/CMakeFiles/yb-admin-test_ent.dir/__/__/__/ent/src/yb/tools/yb-admin-test_ent.cc.o
\-------------------------------------------------------------------------------
@es1024 es1024 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Apr 13, 2022
@es1024 es1024 self-assigned this Apr 13, 2022
es1024 added a commit that referenced this issue Apr 13, 2022
@es1024
[#12150] docdb: Fix gcc9 compile
cfe5beb 
Summary:
gcc9 compile currently fails with the following:

```
/-------------------------------------------------------------------------------
| COMPILATION FAILED
|-------------------------------------------------------------------------------
ent/src/yb/tools/yb-admin-test_ent.cc: In member function ‘virtual void yb::tools::XClusterAdminCliTest_Large_TestBootstrapProducerPerformance_Test::TestBody()’:
ent/src/yb/tools/yb-admin-test_ent.cc:1374:21: error: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<yb::client::TableHandle>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
 1374 |   for (int i = 1; i < tables.size(); ++i) {
      |                   ~~^~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Input files:
  src/yb/tools/CMakeFiles/yb-admin-test_ent.dir/__/__/__/ent/src/yb/tools/yb-admin-test_ent.cc.o
  ent/src/yb/tools/yb-admin-test_ent.cc
Output file (from -o): src/yb/tools/CMakeFiles/yb-admin-test_ent.dir/__/__/__/ent/src/yb/tools/yb-admin-test_ent.cc.o
\-------------------------------------------------------------------------------
```

This diff fixes the compile error.

Test Plan: Jenkins: compile only

Reviewers: sergei, bogdan, nicolas

Reviewed By: nicolas

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D16521
@es1024 es1024 closed this as completed Apr 13, 2022
nspiegelberg added a commit that referenced this issue Apr 29, 2022
@nspiegelberg
[BACKPORT 2.12][#10065][#12150] xCluster: Improve Bootstrap Producer …
e4de5eb 
…Performance

Summary:
The Bootstrap Producer step of XCluster is timing out when run with a larger number of tables (50+).  Added thread parallelism and batching to improve the throughput for large volume configuration.

Original commits:
  6cc0ddd / D14160
  cfe5beb / D16521

Test Plan:
TwoDCTest.BootstrapAndSetupLargeTableCount -n 4

5 Servers, 10 Tables, 10 tablets/T
- Batched: 10 sec
- Normal: 13 sec

Reviewers: rahuldesirazu, slingam, jhe

Reviewed By: jhe

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D16735
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Oct 9, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@es1024 @rthallamko3 @yugabyte-ci